Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.com/openshift/api@release-3.9 #724

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Use github.com/openshift/api@release-3.9 #724

merged 1 commit into from
Apr 26, 2022

Conversation

smuda
Copy link
Contributor

@smuda smuda commented Apr 21, 2022

Description

The project github.com/openshift/api has removed their tags and grafana-operator references the tag v3.9.0, which are unaccessable when not using proxy.golang.org where it's currently cached.

Relevant issues/tickets

#706
openshift/api#456
openshift/api#587
openshift/api#647

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

docker build --no-cache --build-arg GOPROXY=direct .

Copy link
Collaborator

@pb82 pb82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally.

@pb82
Copy link
Collaborator

pb82 commented Apr 26, 2022

@smuda thank you for the contribution, would you mind rebasing? Then we can merge this. Thanks!

@smuda
Copy link
Contributor Author

smuda commented Apr 26, 2022

@pb82 rebased, just waiting for tests.

@NissesSenap NissesSenap merged commit 72ededd into grafana:master Apr 26, 2022
@smuda smuda deleted the feature/706 branch April 27, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants