Use GetCloud from grafana-azure-sdk-go to get resource graph scope and fallback to using clusterUrl for ADX scope for unknown clouds #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aangelisc
reviewed
Apr 22, 2024
| return scopes, nil | ||
| scopeTmpl, ok := "", false | ||
| if scopeTmpl, ok = adxScopes[azureCloud]; !ok { | ||
| scopeTmpl = "{clusterUrl}/.default" |
There was a problem hiding this comment.
I'd add a clarifying comment here that this is applicable for all other clouds
aangelisc
previously approved these changes
Apr 22, 2024
…audienceToScopes pattern found elsewhere in Grafana
JonCole
force-pushed
the
scopes-from-sdk
branch
from
3458a5c
to
c95b293
Compare
|
@aangelisc thanks for the review. I have fixed the merge conflict and added the comment - please take another look. |
aangelisc
approved these changes
Apr 29, 2024
|
Once #875 is merged then we can merge this PR 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using GetCloud from the azure sdk package gives us a consolidated location to get information about a specific cloud, allowing easier expansion of supported clouds in the future. Also, even though Azure Public and Azure China use support special scopes, using the cluster url in the scope is the recommended practice for other clouds.
Fixes #877