Set query database to default if unspecified #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set database from data source default if not specified in query - Throw error if no database on query and no default in data source
|
Use the following command to run this PR with Docker at http://localhost:3000: |
bossinc
reviewed
Apr 17, 2024
|
@bossinc that's a good call-out. The only reason I'm thinking this is worthwhile is to solve the original issue of not wanting to specify the database in generated dashboards. Maybe we should add a default cluster option too? |
@aangelisc lets talk about this next week. I am mixed about how we are doing defaults |
bossinc
previously approved these changes
May 10, 2024
# Conflicts: # pkg/azuredx/datasource_test.go
bossinc
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a query is missing the database property the current behaviour will cause that query to fail. This change will set the database property on the query to the data source default if available.
Fixes #615