New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set query database to default if unspecified #863
Conversation
- Set database from data source default if not specified in query - Throw error if no database on query and no default in data source
Use the following command to run this PR with Docker at http://localhost:3000:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we should do this now that we can select a cluster. If the selected cluster doesn't have the default database (its in another cluster) that seems strange. What do you think?
@bossinc that's a good call-out. The only reason I'm thinking this is worthwhile is to solve the original issue of not wanting to specify the database in generated dashboards. Maybe we should add a default cluster option too? |
@aangelisc lets talk about this next week. I am mixed about how we are doing defaults |
# Conflicts: # pkg/azuredx/datasource_test.go
If a query is missing the database property the current behaviour will cause that query to fail. This change will set the database property on the query to the data source default if available.
Fixes #615