Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictive Test Selection is disabled when running builds #524

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erichaagdev
Copy link
Member

This PR adds the system property -Dpts.enabled=false to build invocations in order to disable PTS. The displayed invocation commands have also been updated to include the system property.

image

ℹ️ Note: The CI/Local experiments (exp5-gradle & exp4-maven) will also be invoked with -Dpts.enabled=false even if the original CI build did not have PTS disabled.

Closes #522

@erichaagdev
Copy link
Member Author

@etiennestuder I want to make sure you see the note I have in the description:

The CI/Local experiments (exp5-gradle & exp4-maven) will also be invoked with -Dpts.enabled=false even if the original CI build did not have PTS disabled.

I think that is the desired state but it means we need to recommend users also disable PTS in the CI builds. Should we also update the wording then of the interactive mode to include this?

${HEADER_COLOR}Run first build on CI agent${RESTORE}
You can now trigger the first build on one of your CI agents. The invoked CI
configuration should be a configuration that is typically triggered when
building the project as part of your pipeline during daily development.
Make sure the CI configuration uses the proper branch and performs a fresh
checkout to avoid any build artifacts lingering around from a previous build
that could influence the experiment.
Once the build completes, make a note of the commit id that was used, and enter
the URL of the build scan produced by the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PTS should be disabled when running experiments
2 participants