Move build summary extraction logic out #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorin-florea
commented
Aug 22, 2023
jthurne
approved these changes
Aug 23, 2023
erichaagdev
reviewed
Aug 23, 2023
etiennestuder
requested changes
Aug 23, 2023
erichaagdev
reviewed
Aug 25, 2023
jthurne
force-pushed
the
sorin/consolidation
branch
from
aa746ec
to
77b69fc
Compare
jthurne
force-pushed
the
sorin/consolidation
branch
from
77b69fc
to
48d7169
Compare
|
Successfully ran the below experiments at commit 0e2028a. |
jthurne
force-pushed
the
sorin/consolidation
branch
from
0e2028a
to
8721a55
Compare
erichaagdev
reviewed
May 9, 2024
|
When I invoke a script I get this right at the start:
Message: /Users/eric/Projects/gradle/gradle-enterprise-gradle-build-validation/local/lib/scripts/exit-code.sh: line 3: SUCCESS: readonly variableTo reproduce it, just run: ./01-validate-incremental-building.sh \
-r git@github.com:gradle/gradle-build-scan-quickstart.git \
-c 710a21dad423192a0ea2d9aea77f381f40eb8a6a \
-t 'build' \
-s https://ge.solutions-team.gradle.com |
|
This is probably an issue with the jar, but I noticed this in debug mode:
|
jthurne
reviewed
May 9, 2024
Fixed in 9fadce5 |
erichaagdev
approved these changes
May 10, 2024
There was a problem hiding this comment.
Everything looks good and works. Approved, but there is still this one unresolved comment: https://github.com/gradle/gradle-enterprise-build-validation-scripts/pull/487/files#r1595971133
…eparate jar `lib/develocity` contains the proprietary code `lib/third-party` contains the third-party open source libraries. In this commit, all OSS libraries are contained in a single jar.
Resolve build scan summary dependencies
erichaagdev
reviewed
May 23, 2024
Co-authored-by: Eric Haag <ehaag@gradle.com> Signed-off-by: Sorin Florea <sorin.florea.v@gmail.com>
|
Did some testing and all looks good up to this point. Each distribution has their respective license and scripts are working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the build scan summary logic into a separate jar file that is built externally to the build validation scripts.
It also restructures the final distribution.
New Gradle scripts distribution layout:
New Maven scripts distribution layout: