Fixes an issue that appears when a block action causes another view to m... #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o make itself a subview of the UIApplication.keywindow. This bug was discovered when the Facebook API was called from a block action, displaying one of the custom FBDialog class windows. The FB API puts this view into the keywindow. When the FBDialog was dismissed, the BlockBackground remained, and made the underlying content unresponsive. This fix moves additional view in the BlockBackground view hierarchy out of itself and into the restored keywindow. This fix may mess with fixes intended to handle multiple sheets to be called within one another and should be tested for this condition.
|
Thanks - I'll try to take a look at these as soon as I'm done dealing with some iOS 7 issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ake itself a subview of the UIApplication.keywindow. This bug was discovered when the Facebook API was called from a block action, displaying one of the custom FBDialog class windows. The FB API puts this view into the keywindow. When the FBDialog was dismissed, the BlockBackground remained, and made the underlying content unresponsive. This fix moves additional views in the BlockBackground view hierarchy out of itself when the time comes to give up keywindow status, and into the restored keywindow.
This fix may mess with fixes intended to handle multiple sheets to be called within one another and should be tested for this condition.