Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FrontEndPages Class #4438

Closed
wants to merge 3 commits into from
Closed

Add FrontEndPages Class #4438

wants to merge 3 commits into from

Conversation

BenjaminWCO
Copy link
Contributor

What

How to review

Checklist

  • Impact on orch and auth mutual dependencies has been checked.
  • A UCD review has been performed.

Related PRs

@BenjaminWCO BenjaminWCO changed the title Bau/add front end api class Add FrontEndAPI Class May 9, 2024
@BenjaminWCO BenjaminWCO force-pushed the BAU/Add-FrontEndApi-Class branch 3 times, most recently from 610009e to 25f7d41 Compare May 9, 2024 23:33
ethanmills
ethanmills reviewed May 10, 2024
View reviewed changes
orchestration-shared/src/main/java/uk/gov/di/orchestration/shared/api/FrontEndAPI.java Outdated

import static uk.gov.di.orchestration.shared.helpers.ConstructUriHelper.buildURI;

public class FrontEndAPI {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the wrong name. The frontend API exists, but this refers to the frontend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that did occur to me. Not really sure what a good name fore it is.

@BenjaminWCO BenjaminWCO force-pushed the BAU/Add-FrontEndApi-Class branch 2 times, most recently from 75fc0ec to 4363b7f Compare May 13, 2024 16:53
@BenjaminWCO BenjaminWCO changed the title Add FrontEndAPI Class Add FrontEndPages Class May 13, 2024
@BenjaminWCO BenjaminWCO deleted the BAU/Add-FrontEndApi-Class branch May 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanmills ethanmills ethanmills left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenjaminWCO @ethanmills