Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-595: Add journey ID to AUTH_USER_INFO_RETURNED audit event #4435

Closed

Conversation

billrdunn
Copy link
Contributor

@billrdunn billrdunn commented May 9, 2024

Co-authored by Isaac Au (@isaac-GDS)

What

Add journey ID (aka client session ID) to AUTH_USER_INFO_RETURNED audit event

How to review

  1. Code review only

Checklist

  • Impact on orch and auth mutual dependencies has been checked.

@billrdunn billrdunn force-pushed the ATO-595/add-client-session-id-to-AUTH_USER_INFO_RETURNED branch from 57a3587 to 08980ae Compare May 9, 2024 14:03
@billrdunn billrdunn force-pushed the ATO-595/add-client-session-id-to-AUTH_USER_INFO_RETURNED branch from 08980ae to a850b1b Compare May 9, 2024 14:04
@billrdunn billrdunn marked this pull request as ready for review May 9, 2024 14:04
@billrdunn billrdunn requested review from a team as code owners May 9, 2024 14:04
Copy link
Member

@ethanmills ethanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably deploy this in two parts: one to start adding the journey ID to the store, then >1ttl later, one to start using it.

@billrdunn
Copy link
Contributor Author

Closing as instead merging in two stages: #4455 and #4456

@billrdunn billrdunn closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants