AUT-2663: introduce auditcontext to make authenticatehandler easier to read #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-cab
changed the title
mark-cab
force-pushed
the
AUT-2663/refactor-authenticatehandler-auditing
branch
2 times, most recently
from
9fb5360
to
911c1d4
Compare
mark-cab
force-pushed
the
AUT-2663/refactor-authenticatehandler-auditing
branch
from
80e429b
to
6353a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
All 4 audit requests in AuthenticateHandler were almost identical. Created a context object that is created initially and gets updated as required before being submitted in an audit event.
How to review
Checklist