Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUT-2162: Part 1: Create Code for new endpoint CheckEmailFraudBlock #4432

Merged
merged 1 commit into from May 17, 2024

Conversation

ayoshebby
Copy link
Contributor

@ayoshebby ayoshebby commented May 9, 2024

What

  • Create new CheckEmailFraudBlock handler that takes email as a request and returns a response containing the email check status
  • The check status can either be ALLOW, DENY, PENDING
  • The email check status is stored in the <env>-email-check-result dynamodb table
  • This lambda will be called during the Create Account journey
  • Implement necessary Iac Terraform scripts to create CheckEmailFraud lambda
  • Deployed and tested in authdev1

How to review

  1. Code Review

@ayoshebby ayoshebby requested review from a team as code owners May 9, 2024 13:27
@ayoshebby ayoshebby force-pushed the AUT-2162 branch 6 times, most recently from 693daa8 to cb71880 Compare May 9, 2024 14:10
@ayoshebby ayoshebby changed the title AUT-2162: Create Code for new endpoint CheckEmailFraudBlock AUT-2162: Part 1: Create Code for new endpoint CheckEmailFraudBlock May 9, 2024
@ayoshebby ayoshebby force-pushed the AUT-2162 branch 13 times, most recently from 028aeef to 7f9d263 Compare May 17, 2024 10:02
alhcomer
alhcomer previously approved these changes May 17, 2024
Copy link
Contributor

@alhcomer alhcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoshebby ayoshebby force-pushed the AUT-2162 branch 3 times, most recently from 9b967f9 to f1f7562 Compare May 17, 2024 14:45
- Create new `CheckEmailFraudBlock` handler that takes `email` as a request and returns a response containing the email check status
- The check status can either be `ALLOW`, `DENY`, `PENDING`
- The email check status is stored in the `<env>-email-check-result` dynamodb table
- This lambda will be called during the Create Account journey

Signed-off-by: ayoshebby <ayo.sebiotimo@digital.cabinet-office.gov.uk>
@ayoshebby ayoshebby added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 2fe0daf May 17, 2024
16 checks passed
@ayoshebby ayoshebby deleted the AUT-2162 branch May 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants