Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAU: ConfigurationService Consistency Improvements #4425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BenjaminWCO
Copy link
Contributor

@BenjaminWCO BenjaminWCO commented May 9, 2024

What

  • Added helper functions in Config Service for common patterns for flags and URIs.
  • Config Service consistently returns URI objects rather than a mix of strings and URIs.
  • URI environment variables no longer default to empty when when missing -will throw instead - this behaviour seemed to be relied on in tests only.
  • More consistent method names in Config Service.

How to review

Code Review

Checklist

  • Impact on orch and auth mutual dependencies has been checked.

@BenjaminWCO BenjaminWCO force-pushed the BAU/Configuration-Service-Consistency-Improvements branch 2 times, most recently from 1750daf to 94aee72 Compare May 13, 2024 16:26
@BenjaminWCO BenjaminWCO changed the title ConfigurationService Consistency Improvements BAU: ConfigurationService Consistency Improvements May 14, 2024
@BenjaminWCO BenjaminWCO marked this pull request as ready for review May 14, 2024 12:29
@BenjaminWCO BenjaminWCO requested review from a team as code owners May 14, 2024 12:29
@BenjaminWCO BenjaminWCO marked this pull request as draft May 14, 2024 12:36
@BenjaminWCO BenjaminWCO force-pushed the BAU/Configuration-Service-Consistency-Improvements branch 2 times, most recently from 6043a28 to c19c808 Compare May 14, 2024 12:49
@BenjaminWCO BenjaminWCO marked this pull request as ready for review May 14, 2024 12:57
@BenjaminWCO BenjaminWCO marked this pull request as draft May 14, 2024 13:47
@BenjaminWCO BenjaminWCO force-pushed the BAU/Configuration-Service-Consistency-Improvements branch 2 times, most recently from 2194394 to a985c38 Compare May 14, 2024 15:47
@BenjaminWCO BenjaminWCO force-pushed the BAU/Configuration-Service-Consistency-Improvements branch from a985c38 to b006268 Compare May 15, 2024 08:13
@BenjaminWCO BenjaminWCO marked this pull request as ready for review May 15, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant