BAU: Remove unused Orch code in auth #4397
Open
+0
−1,136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TokenService file deleted in this commit is no longer used. Orchestration has ownership of the implementation of this functionality, and has created another TokenService file at: orchestration-shared/src/main/java/uk/gov/di/orchestration/shared/services/TokenService.java Our currently used TokenService is located at: auth-external-api/src/main/java/uk/gov/di/authentication/external/services/TokenService.java Our currently used TokenService above generates a token response that allows orchestration to access user info, necessary for their token service implementation.
Methods deleted in this commit are methods that are used for orch functionality and are not used by auth. Orch have all of the methods deleted in this commit in their config service located at: orchestration-shared/src/main/java/uk/gov/di/orchestration/shared/services/ConfigurationService.java
alhcomer
force-pushed
the
BAU/remove-unused-orch-code-in-auth
branch
from
9001a60
to
42465c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request removes the code that is no longer used by us since the Orch/Auth split. The functionality that this code provides is now owned by Orch, and they have implemented similar methods in their parts of the repository.
There are more unused methods in our config service, but I wasn't sure of whether or not we might need them in the future so did not remove them.
How to review
Checklist