ATO-585: Add information to the AUTH_LOG_OUT_SUCCESS audit event #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billrdunn
force-pushed
the
ATO-585/add-userid-to-auth_log_out_success-event
branch
2 times, most recently
from
aaa0d32
to
d170090
Compare
billrdunn
changed the title
subjectId), when it is available, to the LOG_OUT_SUCCESS event
ethanmills
reviewed
May 1, 2024
orchestration-shared/src/main/java/uk/gov/di/orchestration/shared/services/LogoutService.java
Outdated
Show resolved
Hide resolved
billrdunn
force-pushed
the
ATO-585/add-userid-to-auth_log_out_success-event
branch
2 times, most recently
from
56f3a52
to
71b4083
Compare
billrdunn
changed the title
…_LOGOUT_SUCCESS audit event
…rams to LogoutService and generating there
billrdunn
force-pushed
the
ATO-585/add-userid-to-auth_log_out_success-event
branch
7 times, most recently
from
2625690
to
af4e010
Compare
billrdunn
changed the title
billrdunn
force-pushed
the
ATO-585/add-userid-to-auth_log_out_success-event
branch
2 times, most recently
from
b4d5dc3
to
a2c79f4
Compare
billrdunn
changed the title
billrdunn
force-pushed
the
ATO-585/add-userid-to-auth_log_out_success-event
branch
from
a2c79f4
to
7a425e0
Compare
mrwilson
reviewed
May 7, 2024
oidc-api/src/main/java/uk/gov/di/authentication/oidc/lambda/LogoutHandler.java
Outdated
Show resolved
Hide resolved
ethanmills
approved these changes
May 9, 2024
|
Can you update the spreadsheet before merging this one please? |
isaac-GDS
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
subjectId), when it is available, to theAUTH_LOG_OUT_SUCCESSeventAUTH_LOG_OUT_SUCCESSeventI'd like to spend some time in the near future refactoring the logout flows as they are quite convoluted.
How to review
Checklist