Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-554: Add spot request queue cross account access #4362

Merged
merged 1 commit into from May 16, 2024

Conversation

CarlyG55
Copy link
Contributor

What

Allow orchestration access to the spot request queue behind a feature flag

@CarlyG55 CarlyG55 requested review from a team as code owners April 26, 2024 15:22
ci/terraform/oidc/spot-sqs.tf Dismissed Show dismissed Hide dismissed
ci/terraform/oidc/spot-sqs.tf Dismissed Show dismissed Hide dismissed
ci/terraform/oidc/spot-sqs.tf Dismissed Show dismissed Hide dismissed
isaac-GDS
isaac-GDS previously approved these changes Apr 26, 2024
@CarlyG55 CarlyG55 force-pushed the ATO-554/add-spot-queue-cross-account-access branch from 3830a7e to 7433a05 Compare April 29, 2024 09:42
hannah-leong
hannah-leong previously approved these changes Apr 29, 2024
@CarlyG55
Copy link
Contributor Author

Need to pause int & prod to merge

@CarlyG55 CarlyG55 force-pushed the ATO-554/add-spot-queue-cross-account-access branch from 7433a05 to 1c94c19 Compare May 3, 2024 14:05
@CarlyG55 CarlyG55 force-pushed the ATO-554/add-spot-queue-cross-account-access branch from 1c94c19 to bd3cd89 Compare May 14, 2024 10:19
Copy link
Member

@ethanmills ethanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the plan for this with the flag off?

@CarlyG55 CarlyG55 added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 0114696 May 16, 2024
16 checks passed
@CarlyG55 CarlyG55 deleted the ATO-554/add-spot-queue-cross-account-access branch May 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants