INC-760: Do not return an mfa method when none exists #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were defaulting to returning an MFA method of SMS even when none existed. This meant that when a user with a partially created account was going through a password reset journey, they were hitting an error (because we think they have an MFA method of SMS but actually they do not have a verified phone number.
BeckaL
force-pushed
the
INC-760/do-not-return-mfa-method-when-not-verified
branch
from
133549e
to
855bda6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were defaulting to returning an MFA method of SMS even when none existed. This meant that when a user with a partially created account was going through a password reset journey, they were hitting an error (because we think they have an MFA method of SMS but actually they do not have a verified phone number.