added makefile, github-actions and updated go version #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreydaley
suggested changes
Jul 29, 2023
coreydaley
suggested changes
Jul 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage ? 84.44%
=======================================
Files ? 7
Lines ? 598
Branches ? 0
=======================================
Hits ? 505
Misses ? 82
Partials ? 11 |
coreydaley
suggested changes
Jul 30, 2023
auto-merge was automatically disabled
July 30, 2023 06:32
Head branch was pushed to by a user without write access
bharat-rajani
force-pushed
the
bharat-go-update
branch
from
dcefb08
to
ab1e3c1
Compare
coreydaley
approved these changes
Jul 30, 2023
10 tasks
coreydaley
pushed a commit
that referenced
this pull request
Aug 16, 2023
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure that you have: - 📖 Read the Contributing guide: https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md - 📖 Read the Code of Conduct: https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md - Provide tests for your changes. - Use descriptive commit messages. - Comment your code where appropriate. - Squash your commits - Update any related documentation. - Add gorilla/pull-request-reviewers as a Reviewer --> ## What type of PR is this? (check all applicable) - [x] Refactor - [ ] Feature - [ ] Bug Fix - [ ] Optimization - [ ] Documentation Update ## Description A previous commit (#241) replaced most HTTP constants with those from standard library `net/http`, but some was missed. This PR catches 3 of them. ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> - Related Issue: None - Closes: None ## Added/updated tests? - [ ] Yes - [x] No, and this is why: Trivial changes, tests not required - [ ] I need help with writing tests ## Run verifications and test - [ ] `make verify` is passing (which I believe is not my fault) - [x] `make test` is passing
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR aims to
Added/updated tests?
Run verification and test
make verifyis passingmake testis passing