fix: missing key prop #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gorhom 馃憢 Is there any progress on whether this could be considered? |
|
I think this PR fixes #42 |
Whelton
added a commit
to Whelton/react-native-portal
that referenced
this pull request
Jul 11, 2023
If 2 nodes were in the same portal, and one unmounted, the other would be unmounted also in some scenarios. From: gorhom#32
|
Any chance we can get this merged @gorhom? Simple enough to use patch package to apply this, but it would be nice to have it merged + released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gorhom 馃憢
I was using portal for quite some time, alongside some of your other packages, and I have to say they are all awesome! Thank you for them!
I had this (below) error for a long time and was just lazy to fix it until now... Please let me know if this is alright.
P.S. Sorry for the tag, I didn't see your status until it was too late. 馃槗