Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added native modal support #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: added native modal support #16

wants to merge 2 commits into from

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Jul 31, 2021

Summary

this feature will allow user to host their portal at the native root view instead the react native root view.

  • added contained prop to Portal and PortalHost
  • added some of React Native Modal props to Portal to allow more customisation

@gorhom
Copy link
Owner Author

gorhom commented Jul 31, 2021

@nandorojo would you mind testing it :)

@BubbleTrouble14
Copy link

@gorhom Would this patch allow the backdrop on android devices to now also overlay the status bar with the statusBarTranslucent property ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gorhom @BubbleTrouble14