-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/deb package changes #612
base: main
Are you sure you want to change the base?
Feature/deb package changes #612
Conversation
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
…parate struct Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
Thanks for the PR. I didn't have time to read it completely, yet, but I took a glance at the changes. Maybe Distribution and Urgency should be required to set. I'm not sure that setting them automatically to unstable and medium makes sense as we don't even know what is being packaged and for which distro. If people want the metadata these values should probably be deliberate. |
Signed-off-by: ArtemTrofimushkin <artemtrofimushkin@gmail.com>
@erikgeiser Thanks for the explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, thanks for the PR, sorry I missed it earlier...
this LGTM, I believe its only missing the docs changes... can you add them too?
Thanks!
Fixes #488