Use Makefile for CI jobs #3046
Open
Use Makefile for CI jobs #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! thanks |
stephenfin
force-pushed
the
use-makefile-in-ci
branch
from
e621f47
to
6104d02
Compare
stephenfin
force-pushed
the
use-makefile-in-ci
branch
from
6104d02
to
919a982
Compare
github-actions
bot
added
semver:patch
stephenfin
force-pushed
the
use-makefile-in-ci
branch
from
919a982
to
012b916
Compare
github-actions
bot
added
semver:patch
stephenfin
force-pushed
the
use-makefile-in-ci
branch
from
012b916
to
e1ed5a3
Compare
github-actions
bot
added
semver:patch
EmilienM
previously approved these changes
May 22, 2024
|
@EmilienM The failures of the EDIT: tbc, this is separate from the failures against |
github-actions
bot
added
semver:patch
|
@dtantsur FYI |
stephenfin
force-pushed
the
use-makefile-in-ci
branch
from
521d30c
to
8d337d5
Compare
github-actions
bot
added
semver:patch
stephenfin
force-pushed
the
use-makefile-in-ci
branch
from
8d337d5
to
ed25b1f
Compare
github-actions
bot
added
semver:patch
|
aaand of course the master job is passing now. Typical 🙄 There's a new failure but that seems to be an upper-constraint conflict |
It's more common than the object storage service. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We mangled this, probably since we were renaming the 'imageservice' module to 'image' at the time. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
For use in CI. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We can remove the 'acceptancetest' script in the process. Note that this isn't a 1:1 match: the fwaasv2 test job now runs the entire networking test suite and not just the fwaasv2-specific tests but seeing as this is using OVS rather than OVN that doesn't seem like such a bad thing. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
use-makefile-in-ci
branch
from
ed25b1f
to
735bc6a
Compare
github-actions
bot
added
semver:patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start using the Makefile added in #2940 for our CI jobs. This requires #3005 to work correctly.