compute, block storage: Rework scheduler hints #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreprinetti
previously approved these changes
May 3, 2024
stephenfin
dismissed
pierreprinetti’s stale review
The merge-base changed after approval.
pierreprinetti
previously approved these changes
May 3, 2024
|
I can't merge. Do you mind rebasing, to give Github a chance to recover? |
stephenfin
dismissed
pierreprinetti’s stale review
The merge-base changed after approval.
EmilienM
previously approved these changes
May 6, 2024
stephenfin
dismissed
EmilienM’s stale review
The merge-base changed after approval.
EmilienM
previously approved these changes
May 6, 2024
stephenfin
dismissed
EmilienM’s stale review
The merge-base changed after approval.
This is an alternative approach. The main downside is that we now need to pass an additional argument to the volumes.Create function but that seems a more rigorous way to do things. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Do as we did for the block storage equivalent before and unmunge the scheduler hints options from the general server create options. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
scheduler-hints-rework
branch
from
b086566
to
d520ff8
Compare
Apologies, missed this. Done now |
EmilienM
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #2945 and #2938, scheduler hints in the Compute and Block Storage service are slightly weird in that they are passed as separate top-level keys in the request body, rather than nested in the
serverorvolumebodies, respectively.Reflect this API nuance in our own API by exposing these hints as a top-level argument to the
Createfunctions for servers and volumes. This should ease the path to auto-generation down the line and keeps us a little "truer" to the APIs themselves.