Add octavia pool member batch update BatchUpdateMembersAdditiveOnly #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienPensart
force-pushed
the
octavia_pool_member_batch_update_additive_only
branch
from
73c3358
to
b90b180
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
AdrienPensart
force-pushed
the
octavia_pool_member_batch_update_additive_only
branch
from
b90b180
to
668c2aa
Compare
github-actions
bot
added
semver:minor
dulek
reviewed
Jan 11, 2024
Comment on lines
499
to
509
| members := []map[string]interface{}{} | ||
| for _, opt := range opts { | ||
| b, err := opt.ToBatchMemberUpdateMap() | ||
| if err != nil { | ||
| r.Err = err | ||
| return | ||
| } | ||
| members = append(members, b) | ||
| } | ||
|
|
||
| b := map[string]interface{}{"members": members} |
There was a problem hiding this comment.
Looks like code duplication with BatchUpdateMembers() that you could minimize by extracting this into a separate function.
AdrienPensart
force-pushed
the
octavia_pool_member_batch_update_additive_only
branch
from
668c2aa
to
6f1ff3f
Compare
github-actions
bot
added
semver:minor
mandre
reviewed
Jan 24, 2024
AdrienPensart
force-pushed
the
octavia_pool_member_batch_update_additive_only
branch
from
6f1ff3f
to
38a163e
Compare
github-actions
bot
added
semver:unknown
AdrienPensart
force-pushed
the
octavia_pool_member_batch_update_additive_only
branch
from
38a163e
to
8ff2c2d
Compare
github-actions
bot
added
semver:major
AdrienPensart
force-pushed
the
octavia_pool_member_batch_update_additive_only
branch
from
8ff2c2d
to
f7e3160
Compare
Signed-off-by: Adrien Pensart <crunchengine@gmail.com>
AdrienPensart
force-pushed
the
octavia_pool_member_batch_update_additive_only
branch
from
f7e3160
to
6d842c6
Compare
github-actions
bot
added
semver:minor
|
acceptance tests added! |
|
Can we have a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[2862]
Related to https://docs.openstack.org/api-ref/load-balancer/v2/#batch-update-members