octavia: add DomainName and HTTPVersion on monitors (added in 2.10) #2730 #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilienM
reviewed
Aug 25, 2023
| Timeout: 5, | ||
| MaxRetries: 5, | ||
| MaxRetriesDown: 4, | ||
| HTTPVersion: 1.1, |
There was a problem hiding this comment.
Usually we would require something like:
if clients.IsReleasesAbove(t, "stable/XXXX") {
...
But 2.10 is well supported in Train:
https://opendev.org/openstack/octavia/src/branch/stable/train/octavia/api/root_controller.py#L82-L83
So it's ok.
EmilienM
approved these changes
Aug 25, 2023
EmilienM
reviewed
Aug 25, 2023
|
CI seems unhappy now with |
|
Could you please rebase, so it'll trigger CI again and if green I'll merge it. |
|
looking forward to this PR being merged.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2730
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=list-health-monitors-detail#list-health-monitors