Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: exit client on timeout when auto-reconnect is disabled #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

client: exit client on timeout when auto-reconnect is disabled #527

wants to merge 1 commit into from

Conversation

magiconair
Copy link
Member

Fixes #504

@magiconair magiconair added this to the v0.2.4 milestone Dec 9, 2021
@magiconair
Copy link
Member Author

@VereeckenWannes could you have a look whether this addresses your issue in #504 ?

@vereecw
Copy link
Contributor

vereecw commented Dec 9, 2021

This doesn't fix our issue.
The state is still set to disconnected and the subscriptions are still paused.
Plus it won't ever reach this code since the if on line 252 in this file does the same thing.

@magiconair magiconair modified the milestones: v0.2.4, v0.2.5 Jan 3, 2022
@magiconair
Copy link
Member Author

OK, thank you.

@magiconair magiconair modified the milestones: v0.2.5, v0.3 Jan 3, 2022
@magiconair magiconair modified the milestones: v0.3, v0.4 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
future
Development

Successfully merging this pull request may close these issues.

Don't start monitor when AutoReconnect is disabled
2 participants
@magiconair @vereecw