Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DialTimeout and cleanup ResolveEndpoint #372

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add DialTimeout and cleanup ResolveEndpoint #372

wants to merge 2 commits into from

Conversation

kung-foo
Copy link
Member

magiconair
magiconair reviewed Aug 27, 2020
View reviewed changes
uacp/endpoint_test.go
@@ -38,11 +38,12 @@ func TestResolveEndpoint(t *testing.T) {
"",
},
{ // Valid, hostname resolved
"opc.tcp://localhost:4840/foo/bar",
// note: xip.io is hosted by Basecamp (see: https://github.com/basecamp/xip-pdns)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I never knew.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should be in an integration test rather than a normal unit test since it requires a mostly working network stack. 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xip is dead. long live https://sslip.io/

@kung-foo kung-foo added the enhancement New feature or request label Aug 27, 2020
Base automatically changed from master to main March 26, 2021 00:58
@magiconair
Copy link
Member

@kung-foo I've added the DialTimeout and the Dialer to #468 . Maybe you can refactor this so that we get the ResolveEndpoint cleanup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magiconair magiconair magiconair left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kung-foo @magiconair