feat!: Bump minimum to iOS 14 #444
Conversation
There was a problem hiding this comment.
shouldn't you also update the GoogleMaps dependency version in the podspec to 8.0.0?https://github.com/googlemaps/google-maps-ios-utils/blob/main/Google-Maps-iOS-Utils.podspec#L24
And shouldn't you bump the iOS version in the podspec too?
https://github.com/googlemaps/google-maps-ios-utils/blob/main/Google-Maps-iOS-Utils.podspec#L17
|
Any chance this gets merged soon? Running into some bugs that version 8 fixes. |
| @@ -34,11 +34,11 @@ jobs: | |||
| run: sudo gem install cocoapods | |||
|
|
|||
| - name: CocoaPods spec lint | |||
| run: pod lib lint Google-Maps-iOS-Utils.podspec | |||
| run: pod spec lint Google-Maps-iOS-Utils.podspec | |||
There was a problem hiding this comment.
this shouldn't be changed, lib lint validates the local sources, spec lint validates a published tag, since this changes are not published you can't properly test
| @@ -21,24 +21,18 @@ on: | |||
| workflow_dispatch: | |||
| jobs: | |||
| release: | |||
| runs-on: macos-11 | |||
| runs-on: macos-12 | |||
There was a problem hiding this comment.
| runs-on: macos-12 | |
| runs-on: macos-14 |
you can use macos-14 as it's the M1 macs that are faster on building/testing
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| token: ${{ secrets.SYNCED_GITHUB_TOKEN_REPO }} | ||
|
|
||
| - name: Use Xcode 14.2 | ||
| run: sudo xcode-select -s /Applications/Xcode_14.2.app/Contents/Developer | ||
| run: sudo xcode-select -s /Applications/Xcode_14.2.app |
There was a problem hiding this comment.
Xcode 15 is a requirement for publishing apps since last week, I think you should test there instead of 14.2
| - name: Install Dependencies | ||
| run: sudo gem install cocoapods | ||
|
|
||
| - name: CocoaPods spec lint | ||
| run: pod lib lint Google-Maps-iOS-Utils.podspec | ||
| run: pod spec lint Google-Maps-iOS-Utils.podspec |
There was a problem hiding this comment.
same as the previous comment, should not be changed, lib lint should be used
| @@ -52,18 +53,27 @@ pod install | |||
|
|
|||
| ### [Swift Package Manager](https://github.com/apple/swift-package-manager) | |||
|
|
|||
| **Note**: This feature is only available with Swift 5.3 (Xcode 12) or later. | |||
| > [!NOTE] | |||
| > This feature is only available with Swift 5.3 (Xcode 12) or later. | |||
There was a problem hiding this comment.
I don't think the note is required nowadays, Xcode 15 is required for publishing apps on the App Store
| of the Maps SDK for iOS Utility Library that you want to use. For new projects, we recommend specifying the latest version and using the "Exact Version" option. | ||
|
|
||
| 4. Follow the | ||
| [instructions](https://developers.google.com/maps/documentation/ios-sdk/config#get-key) to add your API key to your app. | ||
|
|
||
| ### [Carthage](https://github.com/Carthage/Carthage) |
There was a problem hiding this comment.
This section can be removed or add a note about not being supported anymore
Raise minimum supported OS to iOS 14 to match Maps SDK for iOS 8.0.0
Fixes #456, #458, #459