Set timeout conformance test #1385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout parameter passed into the test proxy server should be used in the client config so that the call ends early
…into set-timeout-conformance-test
Send a copy of gax options downstream to use. Also add logging for the different stream events.
Do grpc logging just for the TestMutateRows_Generic_DeadlineExceeded test. Run the TestMutateRows_Generic_DeadlineExceeded test only.
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: s
console.log the mutate rows requests
Don’t retry in the veneer layer when the stream ends. Also, add logging for the gax stream so that we can measure its behaviour.
We need to show that the gax stream is not sending back data with a DEADLINE_EXCEEDED error and is instead sending back no data at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test demonstrates that when the TestMutateRows_Generic_DeadlineExceeded test is run, the stream closes instead of returning a DEADLINE_EXCEEDED error.