feat: Table deletion protection only relevant #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
…hub.com/danieljbruce/nodejs-bigtable into table-deletion-protection-only-relevant
danieljbruce
changed the title
danieljbruce
added
the
do not merge
…into table-deletion-protection-only-relevant
…hub.com/danieljbruce/nodejs-bigtable into table-deletion-protection-only-relevant
Deletion protection needed to be done at the table level and not the request level so the required change is provided here.
product-auto-label
bot
added
size: m
This PR adds unit tests for table deletion protection for both the true and the false case. The request layer is mocked out like in the other tests.
…hub.com/danieljbruce/nodejs-bigtable into table-deletion-protection-only-relevant
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
danieljbruce
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
danieljbruce
removed
the
do not merge
danieljbruce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes for table deletion protection.
In the createTable method we allow the user to provide a deletionProtection parameter and we pass it along at the table level to the request layer.
System tests and unit tests are added for the true and false cases on the deletionProtection option to capture the desired behaviour of deleting a table when this option is set to true and not deleting a table when the option is set to false.