Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(civil): add Compare method to Date, Time, and DateTime #10193

Conversation

shota3506
Copy link
Contributor

implementation for #10009

This change has been reverted once because of project's go minimum version.
#10010
Right now the project supports >= 1.20, so it should be fine.

@noahdietz noahdietz added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 16, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 16, 2024
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2024
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2024
@noahdietz noahdietz merged commit c2920d7 into googleapis:main May 17, 2024
8 checks passed
@shota3506 shota3506 deleted the civil/add-compare-method-to-date-time-and-datetime branch May 22, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants