feat(storage): add BucketName to BucketHandle #10127
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
reviewed
May 10, 2024
The bucket name is currently only accessible via the Attrs() network call, and can be trivially returned from the bucket handle. I used BucketName instead of just Name, as ObjectHandle has both BucketName and ObjectName.
|
I used the web editor and left a stray tab. That should be resolved now. |
tritone
approved these changes
May 13, 2024
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@tritone any blockers before merging this? |
tritone
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bucket name is currently only accessible via the Attrs() network call, and can be trivially returned from the bucket handle. Today we have to pass around a
BucketHandleand the bucket name separately.I used BucketName instead of just Name, as ObjectHandle has both BucketName and ObjectName.