Add a passthrough example #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proppy
reviewed
May 22, 2024
proppy
reviewed
May 22, 2024
proppy
reviewed
May 22, 2024
rw1nkler
force-pushed
the
passthrough
branch
2 times, most recently
from
f598f4e
to
907a62b
Compare
proppy
reviewed
May 24, 2024
proppy
approved these changes
May 24, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
May 24, 2024
This PR adds a simple proc that forwards the received information from an input channel to an output channel. We found this particular proc surprisingly useful when testing various tools within the toolchain or when reporting bugs. We used it in: * #1415 * #1410 * #1392 * #1057 COPYBARA_INTEGRATE_REVIEW=#1416 from antmicro:passthrough 907a62b PiperOrigin-RevId: 636954688
|
@rw1nkler can you rebase? |
|
The changes have been merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple proc that forwards the received information from an input channel to an output channel. We found this particular proc surprisingly useful when testing various tools within the toolchain or when reporting bugs.
We used it in:
assert!()not working in Procs #1410XlsTypeErrorinconfig()is missing information about the channel direction #1392