Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment on squares, and formatting. #469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabegaster
Copy link

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 13, 2021
# a 2.8x3.5 meter area.
#
# Two encoding algorithms are used. The first 10 characters are pairs of
# characters, one for latitude and one for longitude, using base 20. Each pair
# reduces the area of the code by a factor of 400. Only even code lengths are
# sensible, since an odd-numbered length would have sides in a ratio of 20:1.
# sensible, since an odd-numbered length would have sides in a ratio of 20:1
# (which would not be a square).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the resulting area is not a square doesn't add much here in my opinion.

First, there's the whole issue of all areas not even being rectangles in the first place, because they are lat/long-aligned pieces of sphere surface. Second, even if we accept those as square-ish enough for our purposes, the algorithm will later divide those into 4x5 grids, making longer plus codes less square-ish anyway.

In the end, the rationale for not dividing along one but not the other axis is not that the result is different from a square per se, but the fact that we're interested in minimizing the potential error between the actual location we're putting in and the reference location we're getting back - and having better precision just along one of two axes doesn't help us with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants