Fix java encoding to accept codeLength of 2 and add test cases #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that the encoding tests in most implementations do not account for expected encoding failures like the
https://github.com/google/open-location-code/blob/master/test_data/encoding.csv#L6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encoding of codes with length 2 should be allowed as specified, but the Java implementation unnecessarily limits the
codeLengthto a minimum length of 4 by mistake.This bug was originally discovered by @brewmanz in the C# implementation, which inherited this bug from the Java implementation since day 1.
See discussion in issue #360 (comment)