Add Java 10 Collectors APIs #236
Conversation
|
For some reason I cannot see the rebase option. Do you mind rebasing your PR? |
give me a sec |
treblereel
force-pushed
the
Add_Java_10_Collectors_APIs
branch
from
e8246b9
to
f128f6f
Compare
|
@gkdn done |
|
@gkdn is there anything I can help you with? |
|
Sorry was out of office. Still on my radar, will take a look next week. |
| } | ||
|
|
||
| private static <T, R> Function<T, R> disallowNulls(Function<T, R> func) { | ||
| return func.andThen(Objects::requireNonNull); |
There was a problem hiding this comment.
The reuse is not much here; let's implement this explicitly to avoid extra indirect function call for each item
There was a problem hiding this comment.
Sorry I wasn't clear enough earlier. I meant something like:
private static <T, R> Function<T, R> disallowNulls(Function<T, R> func) {
return x -> Object.requireNonNull(func.apply(x));
}
(otherwise there would be another lambda indirection in each item during collect)
There was a problem hiding this comment.
@treblereel I think you missed this one
There was a problem hiding this comment.
@gkdn thank you, let me take a look ...
| return true; | ||
| } | ||
|
|
||
| public void testToUnmodifiableList() { |
There was a problem hiding this comment.
let's move these tests next to other relevant tests.
| } | ||
|
|
||
| public void testToUnmodifiableList() { | ||
| applyItems(List.of("a", "b"), toUnmodifiableList(), "a", "b", (expected, actual) -> { |
There was a problem hiding this comment.
let's not overload "equals" checking with assertion behavior.
We can do something like:
applyItems(List.of("a", "b"), toUnmodifiableList(), "a", "b")
assertUnmodifiableCollection(applyItemsWithSplitting(...))
Fixes #9547 (cherry picked from commit c5d74f1734bd58a7e3e797a6cc8ca89e2cd7134c)
treblereel
force-pushed
the
Add_Java_10_Collectors_APIs
branch
from
f128f6f
to
cddcb29
Compare
|
@gkdn compile: writing output: write $WORK/b106/pkg.a: no space left on device |
Commented on the other PR, pls ignore the error (or help us out fixing it 😅) |
I never thought that Google might run out of space |
Well it is the Github hosted service not Google 😂 |
| } | ||
| } | ||
|
|
||
| private <K, V> void assertUnmodifiableMap(Map<K, V> a, K existingKey, V existingValue, K newKey, |
There was a problem hiding this comment.
Let's move this helper next to assertUnmodifiableCollection.
(cherry picked from commit c5d74f1734bd58a7e3e797a6cc8ca89e2cd7134c)