Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failed on riscv without rvv #2154

Closed
wants to merge 1 commit into from

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented May 13, 2024

No description provided.

@jan-wassenberg
Copy link
Member

What we are trying to achieve is to compile two codepaths, one with just scalar code, and one with RVV. RVV would only be used if the CPU actually supports it.

In your setting, does the compiler refuse to compile RVV, perhaps because it is configured without it?
If so, I think the better fix would be to disable runtime dispatch entirely because it does not make sense. We will soon allow -DHWY_HAVE_RUNTIME_DISPATCH=0 for that.

@johnplatts
Copy link
Contributor

I have made another change in pull request #2159 that should fix compilation errors with GCC 13 or later on RISC-V if targets.cc is compiled without the -march=rv64gcv1p0 or -march=rv32gcv1p0 option.

@luyahan luyahan closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants