Chocolate Classical Sans: Version 1.001 added #7664

aaronbell · 2024-05-15T05:12:32Z

Taken from the upstream repo https://github.com/aaronbell/ChocolateSans at commit aaronbell/ChocolateSans@ce0c3c5.

Family categorization tags collected from the type design team with the Categories Form
Minisite_url definition in the METADATA.pb file for commissioned projects
Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
Diffenator2 regression checks for revisions on all projects that are currently in production
Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

Taken from the upstream repo https://github.com/aaronbell/ChocolateSans at commit aaronbell/ChocolateSans@ce0c3c5.

aaronbell · 2024-05-15T05:14:40Z

The maintainer of the upstream repro is not responsive to my PR, so am submitting from my local repository. There are existing FAILS that have been reviewed with @chrissimpkins, but if there's any issues let's discuss!

adding a description

github-actions · 2024-05-15T05:54:30Z

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] ChocolateClassicalSans-Regular.ttf

⚠️

WARN Validate location, size and resolution of article images.

⚠️ WARN
Family metadata at ofl/chocolateclassicalsans does not have an article.

[code: lacks-article]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.

ℹ️ INFO
Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[31] ChocolateClassicalSans-Regular.ttf

💥 ERROR Familyname must be unique according to namecheck.fontdata.com

💥 ERROR
Failed to access: http://namecheck.fontdata.com.
This check relies on the external service http://namecheck.fontdata.com via the internet. While the service cannot be reached or does not respond this check is broken.

	You can exclude this check with the command line option:
	-x com.google.fonts/check/fontdata_namecheck

	Or you can wait until the service is available again.
	If the problem persists please report this issue at: https://github.com/fonttools/fontbakery/issues

	Original error message:
	<class 'requests.exceptions.ConnectionError'>

[code: namecheck-service]

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

🔥 FAIL
Repository URL is https://github.com/aaronbell/ChocolateSans

But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans' and OFL text has 'https://github.com/MoonlitOwen/ChocolateSans'

[code: mismatch]

🔥 FAIL Shapes languages in all GF glyphsets.

🔥 FAIL
GF_Latin_Vietnamese glyphset:

Language	FAIL messages
vi_Latn (Vietnamese)	Some mark glyphs were missing: ◌̂, ◌̃, ◌̆, ◌̉, ◌̛, ◌̣

[code: failed-language-shaping]

🔥 FAIL Is this a proper HTML snippet?

🔥 FAIL
ofl/chocolateclassicalsans/DESCRIPTION.en_us.html does not include an HTML
tag.

[code: lacks-paragraph]

🔥 FAIL Ensure files are not too large.

🔥 FAIL
Font file is 9.5Mb, larger than limit 9.0Mb

[code: massive-font]

⚠️

WARN Check glyphs in mark glyph class are non-spacing.

⚠️ WARN
The following spacing glyphs may be in the GDEF mark glyph class by mistake:
uni02EA (U+02EA) and uni02EB (U+02EB)

[code: spacing-mark-glyphs]

⚠️

WARN Check mark characters are in GDEF mark glyph class.

⚠️ WARN
The following mark characters could be in the GDEF mark glyph class:
uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A)

[code: mark-chars]

⚠️

WARN Check GDEF mark glyph class doesn't have characters that are not marks.

⚠️ WARN
The following non-mark characters should not be in the GDEF mark glyph class:
U+02EA and U+02EB

[code: non-mark-chars]

⚠️

WARN Does the font contain chws and vchw features?

⚠️ WARN
chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it.

[code: missing-chws-feature]
⚠️ WARN
vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it.

[code: missing-vchw-feature]

⚠️

WARN Check if each glyph has the recommended amount of contours.

⚠️ WARN
This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni210A	Contours detected: 3	Expected: 2


Glyph name: uni21B9	Contours detected: 2	Expected: 4


Glyph name: uni2552	Contours detected: 1	Expected: 2


Glyph name: uni2553	Contours detected: 1	Expected: 2


Glyph name: uni2555	Contours detected: 1	Expected: 2


Glyph name: uni2556	Contours detected: 1	Expected: 2


Glyph name: uni2558	Contours detected: 1	Expected: 2


Glyph name: uni2559	Contours detected: 1	Expected: 2


Glyph name: uni255B	Contours detected: 1	Expected: 2


Glyph name: uni255C	Contours detected: 1	Expected: 2


12 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]

⚠️

WARN Check math signs have the same width.

⚠️ WARN
The most common width is 1000 among a set of 44 math glyphs.
The following math glyphs have a different width, though:

Width = 555: logicalnot, plus, less, equal, minus, greater

[code: width-outliers]

⚠️

WARN Check font contains no unreachable glyphs

⚠️ WARN
The following glyphs could not be reached by codepoint or substitution rules:

- cid10832

- cid12623

- cid1397

- cid1398

- cid63147

- cid63150

- cid63151

[code: unreachable-glyphs]

⚠️

WARN Glyph names are all valid?

⚠️ WARN
The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
cjkcompatibilityideograph2f825hani, cjkcompatibilityideograph2f83bhani, cjkcompatibilityideograph2f840hani, cjkcompatibilityideograph2f878hani, cjkcompatibilityideograph2f894hani, cjkcompatibilityideograph2f8cdhani, cjkcompatibilityideograph2f994hani, cjkcompatibilityideograph2f9bchani, cjkcompatibilityideograph2f9d4hani, cjkcompatibilityideographf92chani and 100 more.

Use -F or --full-lists to disable shortening of long lists.

[code: legacy-long-names]

⚠️

WARN Do outlines contain any jaggy segments?

⚠️ WARN
The following glyphs have jaggy segments:

* cid12463 (U+555F): L<<181.0,-31.0>--<181.0,279.0>>/B<<181.0,279.0>-<171.0,200.0>-<148.5,121.0>> = 7.214262039206713

* cid38524 (U+8BFF): B<<394.5,99.0>-<396.0,102.0>-<398.0,104.0>>/L<<398.0,104.0>--<171.0,-54.0>> = 10.160722927637101

* cid38550 (U+8C19): L<<527.0,473.0>--<746.0,473.0>>/L<<746.0,473.0>--<716.0,479.0>> = 11.309932474020195

* cid38550 (U+8C19): L<<937.0,620.0>--<838.0,620.0>>/L<<838.0,620.0>--<855.0,617.0>> = 10.00797980144135

* cid38551 (U+8C1A): L<<940.0,675.0>--<833.0,675.0>>/L<<833.0,675.0>--<860.0,669.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<473.0,628.0>--<520.0,636.0>>/L<<520.0,636.0>--<371.0,636.0>> = 9.65989307844234

* cid38561 (U+8C24): L<<564.0,518.0>--<730.0,518.0>>/L<<730.0,518.0>--<721.0,520.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<582.0,522.0>--<564.0,518.0>>/L<<564.0,518.0>--<730.0,518.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<928.0,636.0>--<836.0,636.0>>/L<<836.0,636.0>--<845.0,634.0>> = 12.528807709151522

* cid38567 (U+8C2A): L<<462.0,596.0>--<483.0,599.0>>/L<<483.0,599.0>--<353.0,599.0>> = 8.13010235415596

* 2336 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]

⚠️

WARN Do outlines contain any semi-vertical or semi-horizontal lines?

⚠️ WARN
The following glyphs have semi-vertical/semi-horizontal lines:

* cid38436 (U+8BA7): L<<203.0,58.0>--<204.0,441.0>>

* cid38436 (U+8BA7): L<<275.0,513.0>--<274.0,111.0>>

* cid38559 (U+8C22): L<<346.0,279.0>--<345.0,739.0>>

* cid38561 (U+8C24): L<<357.0,517.0>--<509.0,518.0>>

* cid38561 (U+8C24): L<<793.0,518.0>--<947.0,519.0>>

* cid59546 (U+203CB): L<<638.0,469.0>--<883.0,468.0>>

* cid59597 (U+20873): L<<693.0,611.0>--<694.0,840.0>>

* cid59641 (U+20C43): L<<729.0,305.0>--<598.0,304.0>>

* cid59851 (U+216BA): L<<564.0,632.0>--<565.0,839.0>>

* cid59893 (U+217DA): L<<868.0,634.0>--<726.0,635.0>>

* 465 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]

⚠️

WARN Check the direction of the outermost contour in each glyph

⚠️ WARN
The following glyphs have a counter-clockwise outer contour:

* acutecomb (U+0301) has a counter-clockwise outer contour

* cid10339 (U+5036) has a counter-clockwise outer contour

* cid38574 (U+8C31) has a counter-clockwise outer contour

* cid59527 (U+202BF) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59545 (U+203C9) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* 7815 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]

⚠️

WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.

⚠️ WARN
The dot of soft dotted characters used in orthographies must disappear in the following strings: j̀ j́ j̄ ị̀ ị́ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̇ i⃝̀ i⃝́ i⃝̄ i⃝̇ i⃝̌ i⃞̀ i⃞́ i⃞̄ i⃞̇ i⃞̌ j̇ ǰ j⃝̀ j⃝́ j⃝̄ j⃝̇ j⃝̌ j⃞̀ j⃞́

Your font does not cover the following languages that require the soft-dotted feature: Vute (Latn, 21,000 speakers), Bafut (Latn, 158,146 speakers), Dutch (Latn, 31,709,104 speakers), South Central Banda (Latn, 244,000 speakers), Igbo (Latn, 27,823,640 speakers), Ekpeye (Latn, 226,000 speakers), Aghem (Latn, 38,843 speakers), Kom (Latn, 360,685 speakers), Bete-Bendi (Latn, 100,000 speakers), Mango (Latn, 77,000 speakers), Avokaya (Latn, 100,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Lithuanian (Latn, 2,357,094 speakers), Dii (Latn, 71,000 speakers), Basaa (Latn, 332,940 speakers), Southern Kisi (Latn, 360,000 speakers), Dan (Latn, 1,099,244 speakers), Mfumte (Latn, 79,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Makaa (Latn, 221,000 speakers), Fur (Latn, 1,230,163 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Koonzime (Latn, 40,000 speakers), Cicipu (Latn, 44,000 speakers), Lugbara (Latn, 2,200,000 speakers), Mundani (Latn, 34,000 speakers), Nateni (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Nzakara (Latn, 50,000 speakers), Navajo (Latn, 166,319 speakers), Yala (Latn, 200,000 speakers), Ebira (Latn, 2,200,000 speakers), Zapotec (Latn, 490,000 speakers), Gulay (Latn, 250,478 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ma’di (Latn, 584,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Ejagham (Latn, 120,000 speakers).

[code: soft-dotted]

⚠️

WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?

⚠️ WARN
It seems that Moonlit Owen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.

[code: profile-not-found]

⚠️

WARN Check for codepoints not covered by METADATA subsets.

⚠️ WARN
The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.

U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi
U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
U+02EA MODIFIER LETTER YIN DEPARTING TONE MARK: not included in any glyphset definition
U+02EB MODIFIER LETTER YANG DEPARTING TONE MARK: not included in any glyphset definition
U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, tifinagh, canadian-aboriginal, malayalam, tai-le, math, coptic, syriac
U+030C COMBINING CARON: try adding one of: cherokee, tai-le
U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: math, elbasan, greek 20755 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, chinese-simplified, chinese-traditional, cyrillic, japanese, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]

⚠️

WARN DESCRIPTION.en_us.html should end in a linebreak.

⚠️ WARN
The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.

[code: missing-eof-linebreak]

⚠️

WARN Combined length of family and style must not exceed 32 characters.

⚠️ WARN
Name ID 6 'ChocolateClassicalSans-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.

[code: nameid6-too-long]

⚠️

WARN Is there kerning info for non-ligated sequences?

⚠️ WARN
GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️

WARN Are there caret positions declared for every ligature?

⚠️ WARN
This font lacks caret position values for ligature glyphs on its GDEF table.

[code: lacks-caret-pos]

⚠️

WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.

⚠️ WARN
This font file does not have a 'meta' table.

[code: lacks-meta-table]

ℹ️ INFO List all superfamily filepaths

ℹ️ INFO
ofl/chocolateclassicalsans

[code: family-path]

ℹ️ INFO Font contains all required tables?

ℹ️ INFO
This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file

ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]

ℹ️ INFO EPAR table present in font?

ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818

[code: lacks-EPAR]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?

ℹ️ INFO
These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]

ℹ️ INFO Show hinting filesize impact.

ℹ️ INFO
Hinting filesize impact:

	ofl/chocolateclassicalsans/ChocolateClassicalSans-Regular.ttf
Dehinted Size	9.5Mb
Hinted Size	9.5Mb
Increase	24 bytes
Change	0.0 %

[code: size-impact]

ℹ️ INFO Font has old ttfautohint applied?

ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']

[code: version-not-detected]

[1] Family checks

ℹ️ INFO Check axis ordering on the STAT table.

ℹ️ INFO
All of the fonts lack a STAT table.

[code: summary]

Summary

💥 ERROR	☠ FATAL	🔥 FAIL	⚠️ WARN	⏩ SKIP	ℹ️ INFO	✅ PASS	🔎 DEBUG
1	0	4	20	66	9	151	0
0%	0%	2%	8%	26%	4%	60%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

emmamarichal · 2024-05-15T13:30:50Z

Review - Part I: Fontbakery

Please note that I don't know the context and agreements with this font, so I prefer to check everything, I just need some confirmation :)
My remarks will be pretty similar to the Cactus ones.

🔥 FAIL Shapes languages in all GF glyphsets.
vi_Latn (Vietnamese) Some mark glyphs were missing: ◌̃, ◌̉, ◌̛, ◌̣
-> This is the only marks missing, could we solve this to avoid the fail?

🔥 FAIL Ensure files are not too large.
-> I suppose that's inevitable for a CJK font

🔥 FAIL Check Google Fonts glyph coverage.
-> Can you confirm that it's ok and agreed the font doesn't cover the Latin Core glyphset?

⚠️ WARN Are there caret positions declared for every ligature?
-> Don't know how ligatures are made in CJK. Is it possible to solve this? We don't have it in Cactus.

ofl/chocolateclassicalsans/DESCRIPTION.en_us.html

ofl/chocolateclassicalsans/OFL.txt

emmamarichal · 2024-05-15T14:01:11Z

Part II: Outlines / Spacing

I didn't asked for Cactus, but are we happy with this kind of spacing?

A some small issue in spacing: it concerns /uni20DD/uni20DE

aaronbell · 2024-05-15T18:20:31Z

🔥 FAIL Shapes languages in all GF glyphsets. vi_Latn (Vietnamese) Some mark glyphs were missing: ◌̃, ◌̉, ◌̛, ◌̣ -> This is the only marks missing, could we solve this to avoid the fail?

Done

🔥 FAIL Ensure files are not too large. -> I suppose that's inevitable for a CJK font

Yup...

🔥 FAIL Check Google Fonts glyph coverage. -> Can you confirm that it's ok and agreed the font doesn't cover the Latin Core glyphset?

Confirmed. Latin Kernel is sufficient!

⚠️ WARN Are there caret positions declared for every ligature? -> Don't know how ligatures are made in CJK. Is it possible to solve this? We don't have it in Cactus.

The only ligatures that I'm seeing in the font are Latin ones for fl, fi, and ffi. Cactus doesn't have any liga substitutions because Chocolate Sans is based on Source Han Sans, so it has different capabilites. I don't think this is anything we need to worry about.

aaronbell · 2024-05-15T18:26:29Z

Part II: Outlines / Spacing

* I didn't asked for Cactus, but are we happy with this kind of spacing?

This is fine. TC punctuation works differently than we expect, so the centered positionings are fine.

For 20DD and 20DE, these are enclosing glyphs, meant to be positioned over the previous glyph, so I think it is OK for these to be as they are.

aaronbell · 2024-05-15T18:32:03Z

Updated

github-actions · 2024-05-15T18:40:36Z

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] ChocolateClassicalSans-Regular.ttf

⚠️

WARN Validate location, size and resolution of article images.

⚠️ WARN
Family metadata at ofl/chocolateclassicalsans does not have an article.

[code: lacks-article]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.

ℹ️ INFO
Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[30] ChocolateClassicalSans-Regular.ttf

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

🔥 FAIL
Repository URL is https://github.com/aaronbell/ChocolateSans

But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans' and OFL text has 'https://github.com/MoonlitOwen/ChocolateSans'

[code: mismatch]

🔥 FAIL Shapes languages in all GF glyphsets.

🔥 FAIL
GF_Latin_Vietnamese glyphset:

Language	FAIL messages
vi_Latn (Vietnamese)	Some mark glyphs were missing: ◌̂, ◌̆

[code: failed-language-shaping]

🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?

🔥 FAIL
Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.

[code: lacks-git-url]

🔥 FAIL Ensure files are not too large.

🔥 FAIL
Font file is 9.5Mb, larger than limit 9.0Mb

[code: massive-font]

⚠️

WARN Check glyphs in mark glyph class are non-spacing.

⚠️ WARN
The following spacing glyphs may be in the GDEF mark glyph class by mistake:
uni02EA (U+02EA) and uni02EB (U+02EB)

[code: spacing-mark-glyphs]

⚠️

WARN Check mark characters are in GDEF mark glyph class.

⚠️ WARN
The following mark characters could be in the GDEF mark glyph class:
dotbelowcomb (U+0323), hookabovecomb (U+0309), horncomb (U+031B), tildecomb (U+0303), uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C) and 3 more.

Use -F or --full-lists to disable shortening of long lists.

[code: mark-chars]

⚠️

WARN Check GDEF mark glyph class doesn't have characters that are not marks.

⚠️ WARN
The following non-mark characters should not be in the GDEF mark glyph class:
U+02EA and U+02EB

[code: non-mark-chars]

⚠️

WARN Does the font contain chws and vchw features?

⚠️ WARN
chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it.

[code: missing-chws-feature]
⚠️ WARN
vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it.

[code: missing-vchw-feature]

⚠️

WARN Check if each glyph has the recommended amount of contours.

⚠️ WARN
This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni210A	Contours detected: 3	Expected: 2


Glyph name: uni21B9	Contours detected: 2	Expected: 4


Glyph name: uni2552	Contours detected: 1	Expected: 2


Glyph name: uni2553	Contours detected: 1	Expected: 2


Glyph name: uni2555	Contours detected: 1	Expected: 2


Glyph name: uni2556	Contours detected: 1	Expected: 2


Glyph name: uni2558	Contours detected: 1	Expected: 2


Glyph name: uni2559	Contours detected: 1	Expected: 2


Glyph name: uni255B	Contours detected: 1	Expected: 2


Glyph name: uni255C	Contours detected: 1	Expected: 2


12 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]

⚠️

WARN Check math signs have the same width.

⚠️ WARN
The most common width is 1000 among a set of 44 math glyphs.
The following math glyphs have a different width, though:

Width = 555: less, greater, equal, minus, plus, logicalnot

[code: width-outliers]

⚠️

WARN Check font contains no unreachable glyphs

⚠️ WARN
The following glyphs could not be reached by codepoint or substitution rules:

- cid10832

- cid12623

- cid1397

- cid1398

- cid63147

- cid63150

- cid63151

[code: unreachable-glyphs]

⚠️

WARN Glyph names are all valid?

⚠️ WARN
The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
cjkcompatibilityideograph2f825hani, cjkcompatibilityideograph2f83bhani, cjkcompatibilityideograph2f840hani, cjkcompatibilityideograph2f878hani, cjkcompatibilityideograph2f894hani, cjkcompatibilityideograph2f8cdhani, cjkcompatibilityideograph2f994hani, cjkcompatibilityideograph2f9bchani, cjkcompatibilityideograph2f9d4hani, cjkcompatibilityideographf92chani and 100 more.

Use -F or --full-lists to disable shortening of long lists.

[code: legacy-long-names]

⚠️

WARN Do outlines contain any jaggy segments?

⚠️ WARN
The following glyphs have jaggy segments:

* cid12463 (U+555F): L<<181.0,-31.0>--<181.0,279.0>>/B<<181.0,279.0>-<171.0,200.0>-<148.5,121.0>> = 7.214262039206713

* cid38524 (U+8BFF): B<<394.5,99.0>-<396.0,102.0>-<398.0,104.0>>/L<<398.0,104.0>--<171.0,-54.0>> = 10.160722927637101

* cid38550 (U+8C19): L<<527.0,473.0>--<746.0,473.0>>/L<<746.0,473.0>--<716.0,479.0>> = 11.309932474020195

* cid38550 (U+8C19): L<<937.0,620.0>--<838.0,620.0>>/L<<838.0,620.0>--<855.0,617.0>> = 10.00797980144135

* cid38551 (U+8C1A): L<<940.0,675.0>--<833.0,675.0>>/L<<833.0,675.0>--<860.0,669.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<473.0,628.0>--<520.0,636.0>>/L<<520.0,636.0>--<371.0,636.0>> = 9.65989307844234

* cid38561 (U+8C24): L<<564.0,518.0>--<730.0,518.0>>/L<<730.0,518.0>--<721.0,520.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<582.0,522.0>--<564.0,518.0>>/L<<564.0,518.0>--<730.0,518.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<928.0,636.0>--<836.0,636.0>>/L<<836.0,636.0>--<845.0,634.0>> = 12.528807709151522

* cid38567 (U+8C2A): L<<462.0,596.0>--<483.0,599.0>>/L<<483.0,599.0>--<353.0,599.0>> = 8.13010235415596

* 2336 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]

⚠️

WARN Do outlines contain any semi-vertical or semi-horizontal lines?

⚠️ WARN
The following glyphs have semi-vertical/semi-horizontal lines:

* cid38436 (U+8BA7): L<<203.0,58.0>--<204.0,441.0>>

* cid38436 (U+8BA7): L<<275.0,513.0>--<274.0,111.0>>

* cid38559 (U+8C22): L<<346.0,279.0>--<345.0,739.0>>

* cid38561 (U+8C24): L<<357.0,517.0>--<509.0,518.0>>

* cid38561 (U+8C24): L<<793.0,518.0>--<947.0,519.0>>

* cid59546 (U+203CB): L<<638.0,469.0>--<883.0,468.0>>

* cid59597 (U+20873): L<<693.0,611.0>--<694.0,840.0>>

* cid59641 (U+20C43): L<<729.0,305.0>--<598.0,304.0>>

* cid59851 (U+216BA): L<<564.0,632.0>--<565.0,839.0>>

* cid59893 (U+217DA): L<<868.0,634.0>--<726.0,635.0>>

* 465 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]

⚠️

WARN Check the direction of the outermost contour in each glyph

⚠️ WARN
The following glyphs have a counter-clockwise outer contour:

* acutecomb (U+0301) has a counter-clockwise outer contour

* cid10339 (U+5036) has a counter-clockwise outer contour

* cid38574 (U+8C31) has a counter-clockwise outer contour

* cid59527 (U+202BF) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59545 (U+203C9) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* 7815 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]

⚠️

WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.

⚠️ WARN
The dot of soft dotted characters used in orthographies must disappear in the following strings: j̀ j́ j̃ j̄ ị̀ ị́ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̇ i̛̇ i⃝̀ i⃝́ i⃝̃ i⃝̄ i⃝̇ i⃝̉ i⃝̌ i⃞̀ i⃞́ i⃞̃ i⃞̄ i⃞̇ i⃞̉ i⃞̌ j̇ j̉ ǰ j̛̀

Your font does not cover the following languages that require the soft-dotted feature: Fur (Latn, 1,230,163 speakers), Dutch (Latn, 31,709,104 speakers), Mango (Latn, 77,000 speakers), Dii (Latn, 71,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Vute (Latn, 21,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Navajo (Latn, 166,319 speakers), Zapotec (Latn, 490,000 speakers), Ejagham (Latn, 120,000 speakers), Kom (Latn, 360,685 speakers), Basaa (Latn, 332,940 speakers), Igbo (Latn, 27,823,640 speakers), Bete-Bendi (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Cicipu (Latn, 44,000 speakers), Lugbara (Latn, 2,200,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Dan (Latn, 1,099,244 speakers), Mundani (Latn, 34,000 speakers), Mfumte (Latn, 79,000 speakers), Bafut (Latn, 158,146 speakers), Avokaya (Latn, 100,000 speakers), Nateni (Latn, 100,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ebira (Latn, 2,200,000 speakers), Makaa (Latn, 221,000 speakers), Yala (Latn, 200,000 speakers), Ma’di (Latn, 584,000 speakers), Nzakara (Latn, 50,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Gulay (Latn, 250,478 speakers), Ekpeye (Latn, 226,000 speakers), Koonzime (Latn, 40,000 speakers), South Central Banda (Latn, 244,000 speakers), Southern Kisi (Latn, 360,000 speakers), Aghem (Latn, 38,843 speakers).

[code: soft-dotted]

⚠️

WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?

⚠️ WARN
It seems that Moonlit Owen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.

[code: profile-not-found]

⚠️

WARN Check for codepoints not covered by METADATA subsets.

⚠️ WARN
The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.

U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh
U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
U+02EA MODIFIER LETTER YIN DEPARTING TONE MARK: not included in any glyphset definition
U+02EB MODIFIER LETTER YANG DEPARTING TONE MARK: not included in any glyphset definition
U+0307 COMBINING DOT ABOVE: try adding one of: syriac, tai-le, tifinagh, math, coptic, malayalam, canadian-aboriginal, old-permic
U+030C COMBINING CARON: try adding one of: tai-le, cherokee
U+031B COMBINING HORN: not included in any glyphset definition 20756 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, chinese-simplified, chinese-traditional, cyrillic, japanese, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]

⚠️

WARN DESCRIPTION.en_us.html should end in a linebreak.

⚠️ WARN
The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.

[code: missing-eof-linebreak]

⚠️

WARN Combined length of family and style must not exceed 32 characters.

⚠️ WARN
Name ID 6 'ChocolateClassicalSans-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.

[code: nameid6-too-long]

⚠️

WARN Is there kerning info for non-ligated sequences?

⚠️ WARN
GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️

WARN Are there caret positions declared for every ligature?

⚠️ WARN
This font lacks caret position values for ligature glyphs on its GDEF table.

[code: lacks-caret-pos]

⚠️

WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.

⚠️ WARN
This font file does not have a 'meta' table.

[code: lacks-meta-table]

ℹ️ INFO List all superfamily filepaths

ℹ️ INFO
ofl/chocolateclassicalsans

[code: family-path]

ℹ️ INFO Font contains all required tables?

ℹ️ INFO
This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file

ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]

ℹ️ INFO EPAR table present in font?

ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818

[code: lacks-EPAR]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?

ℹ️ INFO
These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]

ℹ️ INFO Show hinting filesize impact.

ℹ️ INFO
Hinting filesize impact:

	ofl/chocolateclassicalsans/ChocolateClassicalSans-Regular.ttf
Dehinted Size	9.5Mb
Hinted Size	9.5Mb
Increase	24 bytes
Change	0.0 %

[code: size-impact]

ℹ️ INFO Font has old ttfautohint applied?

ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']

[code: version-not-detected]

[1] Family checks

ℹ️ INFO Check axis ordering on the STAT table.

ℹ️ INFO
All of the fonts lack a STAT table.

[code: summary]

Summary

💥 ERROR	☠ FATAL	🔥 FAIL	⚠️ WARN	⏩ SKIP	ℹ️ INFO	✅ PASS	🔎 DEBUG
0	0	4	20	63	9	155	0
0%	0%	2%	8%	25%	4%	62%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

ofl/chocolateclassicalsans/DESCRIPTION.en_us.html

Co-authored-by: Henry Chan <hfhchan@users.noreply.github.com>

emmamarichal · 2024-05-16T08:31:03Z

@hfhchan, I commited your changes, I propose we go ahead, and we will add modifications if they are needed :)

emmamarichal · 2024-05-16T08:33:44Z

@hfhchan should we add Tian Haidong in the designers list for this font? (in the metadatas and specimen)

github-actions · 2024-05-16T08:41:05Z

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] ChocolateClassicalSans-Regular.ttf

⚠️

WARN Validate location, size and resolution of article images.

⚠️ WARN
Family metadata at ofl/chocolateclassicalsans does not have an article.

[code: lacks-article]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.

ℹ️ INFO
Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[29] ChocolateClassicalSans-Regular.ttf

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

🔥 FAIL
Repository URL is https://github.com/aaronbell/ChocolateSans

But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans', OFL text has 'https://github.com/MoonlitOwen/ChocolateSans' and HTML description has 'github.com/MoonlitOwen/ChocolateSans'

[code: mismatch]

🔥 FAIL Shapes languages in all GF glyphsets.

🔥 FAIL
GF_Latin_Vietnamese glyphset:

Language	FAIL messages
vi_Latn (Vietnamese)	Some mark glyphs were missing: ◌̂, ◌̆

[code: failed-language-shaping]

🔥 FAIL Ensure files are not too large.

🔥 FAIL
Font file is 9.5Mb, larger than limit 9.0Mb

[code: massive-font]

⚠️

WARN Check glyphs in mark glyph class are non-spacing.

⚠️ WARN
The following spacing glyphs may be in the GDEF mark glyph class by mistake:
uni02EA (U+02EA) and uni02EB (U+02EB)

[code: spacing-mark-glyphs]

⚠️

WARN Check mark characters are in GDEF mark glyph class.

⚠️ WARN
The following mark characters could be in the GDEF mark glyph class:
dotbelowcomb (U+0323), hookabovecomb (U+0309), horncomb (U+031B), tildecomb (U+0303), uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C) and 3 more.

Use -F or --full-lists to disable shortening of long lists.

[code: mark-chars]

⚠️

WARN Check GDEF mark glyph class doesn't have characters that are not marks.

⚠️ WARN
The following non-mark characters should not be in the GDEF mark glyph class:
U+02EA and U+02EB

[code: non-mark-chars]

⚠️

WARN Does the font contain chws and vchw features?

⚠️ WARN
chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it.

[code: missing-chws-feature]
⚠️ WARN
vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it.

[code: missing-vchw-feature]

⚠️

WARN Check if each glyph has the recommended amount of contours.

⚠️ WARN
This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni210A	Contours detected: 3	Expected: 2


Glyph name: uni21B9	Contours detected: 2	Expected: 4


Glyph name: uni2552	Contours detected: 1	Expected: 2


Glyph name: uni2553	Contours detected: 1	Expected: 2


Glyph name: uni2555	Contours detected: 1	Expected: 2


Glyph name: uni2556	Contours detected: 1	Expected: 2


Glyph name: uni2558	Contours detected: 1	Expected: 2


Glyph name: uni2559	Contours detected: 1	Expected: 2


Glyph name: uni255B	Contours detected: 1	Expected: 2


Glyph name: uni255C	Contours detected: 1	Expected: 2


12 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]

⚠️

WARN Check math signs have the same width.

⚠️ WARN
The most common width is 1000 among a set of 44 math glyphs.
The following math glyphs have a different width, though:

Width = 555: logicalnot, minus, less, greater, equal, plus

[code: width-outliers]

⚠️

WARN Check font contains no unreachable glyphs

⚠️ WARN
The following glyphs could not be reached by codepoint or substitution rules:

- cid10832

- cid12623

- cid1397

- cid1398

- cid63147

- cid63150

- cid63151

[code: unreachable-glyphs]

⚠️

WARN Glyph names are all valid?

⚠️ WARN
The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
cjkcompatibilityideograph2f825hani, cjkcompatibilityideograph2f83bhani, cjkcompatibilityideograph2f840hani, cjkcompatibilityideograph2f878hani, cjkcompatibilityideograph2f894hani, cjkcompatibilityideograph2f8cdhani, cjkcompatibilityideograph2f994hani, cjkcompatibilityideograph2f9bchani, cjkcompatibilityideograph2f9d4hani, cjkcompatibilityideographf92chani and 100 more.

Use -F or --full-lists to disable shortening of long lists.

[code: legacy-long-names]

⚠️

WARN Do outlines contain any jaggy segments?

⚠️ WARN
The following glyphs have jaggy segments:

* cid12463 (U+555F): L<<181.0,-31.0>--<181.0,279.0>>/B<<181.0,279.0>-<171.0,200.0>-<148.5,121.0>> = 7.214262039206713

* cid38524 (U+8BFF): B<<394.5,99.0>-<396.0,102.0>-<398.0,104.0>>/L<<398.0,104.0>--<171.0,-54.0>> = 10.160722927637101

* cid38550 (U+8C19): L<<527.0,473.0>--<746.0,473.0>>/L<<746.0,473.0>--<716.0,479.0>> = 11.309932474020195

* cid38550 (U+8C19): L<<937.0,620.0>--<838.0,620.0>>/L<<838.0,620.0>--<855.0,617.0>> = 10.00797980144135

* cid38551 (U+8C1A): L<<940.0,675.0>--<833.0,675.0>>/L<<833.0,675.0>--<860.0,669.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<473.0,628.0>--<520.0,636.0>>/L<<520.0,636.0>--<371.0,636.0>> = 9.65989307844234

* cid38561 (U+8C24): L<<564.0,518.0>--<730.0,518.0>>/L<<730.0,518.0>--<721.0,520.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<582.0,522.0>--<564.0,518.0>>/L<<564.0,518.0>--<730.0,518.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<928.0,636.0>--<836.0,636.0>>/L<<836.0,636.0>--<845.0,634.0>> = 12.528807709151522

* cid38567 (U+8C2A): L<<462.0,596.0>--<483.0,599.0>>/L<<483.0,599.0>--<353.0,599.0>> = 8.13010235415596

* 2336 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]

⚠️

WARN Do outlines contain any semi-vertical or semi-horizontal lines?

⚠️ WARN
The following glyphs have semi-vertical/semi-horizontal lines:

* cid38436 (U+8BA7): L<<203.0,58.0>--<204.0,441.0>>

* cid38436 (U+8BA7): L<<275.0,513.0>--<274.0,111.0>>

* cid38559 (U+8C22): L<<346.0,279.0>--<345.0,739.0>>

* cid38561 (U+8C24): L<<357.0,517.0>--<509.0,518.0>>

* cid38561 (U+8C24): L<<793.0,518.0>--<947.0,519.0>>

* cid59546 (U+203CB): L<<638.0,469.0>--<883.0,468.0>>

* cid59597 (U+20873): L<<693.0,611.0>--<694.0,840.0>>

* cid59641 (U+20C43): L<<729.0,305.0>--<598.0,304.0>>

* cid59851 (U+216BA): L<<564.0,632.0>--<565.0,839.0>>

* cid59893 (U+217DA): L<<868.0,634.0>--<726.0,635.0>>

* 465 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]

⚠️

WARN Check the direction of the outermost contour in each glyph

⚠️ WARN
The following glyphs have a counter-clockwise outer contour:

* acutecomb (U+0301) has a counter-clockwise outer contour

* cid10339 (U+5036) has a counter-clockwise outer contour

* cid38574 (U+8C31) has a counter-clockwise outer contour

* cid59527 (U+202BF) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59545 (U+203C9) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* 7815 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]

⚠️

WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.

⚠️ WARN
The dot of soft dotted characters used in orthographies must disappear in the following strings: j̀ j́ j̃ j̄ ị̀ ị́ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̇ i̛̇ i⃝̀ i⃝́ i⃝̃ i⃝̄ i⃝̇ i⃝̉ i⃝̌ i⃞̀ i⃞́ i⃞̃ i⃞̄ i⃞̇ i⃞̉ i⃞̌ j̇ j̉ ǰ j̛̀

Your font does not cover the following languages that require the soft-dotted feature: South Central Banda (Latn, 244,000 speakers), Mfumte (Latn, 79,000 speakers), Fur (Latn, 1,230,163 speakers), Dutch (Latn, 31,709,104 speakers), Aghem (Latn, 38,843 speakers), Koonzime (Latn, 40,000 speakers), Sar (Latn, 500,000 speakers), Igbo (Latn, 27,823,640 speakers), Bete-Bendi (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers), Avokaya (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ejagham (Latn, 120,000 speakers), Gulay (Latn, 250,478 speakers), Vute (Latn, 21,000 speakers), Navajo (Latn, 166,319 speakers), Nateni (Latn, 100,000 speakers), Cicipu (Latn, 44,000 speakers), Mango (Latn, 77,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ekpeye (Latn, 226,000 speakers), Bafut (Latn, 158,146 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Dii (Latn, 71,000 speakers), Mundani (Latn, 34,000 speakers), Nzakara (Latn, 50,000 speakers), Makaa (Latn, 221,000 speakers), Yala (Latn, 200,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Basaa (Latn, 332,940 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers), Dan (Latn, 1,099,244 speakers), Ebira (Latn, 2,200,000 speakers), Kom (Latn, 360,685 speakers), Ma’di (Latn, 584,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers).

[code: soft-dotted]

⚠️

WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?

⚠️ WARN
It seems that Moonlit Owen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.

[code: profile-not-found]

⚠️

WARN Check for codepoints not covered by METADATA subsets.

⚠️ WARN
The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.

U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi
U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
U+02EA MODIFIER LETTER YIN DEPARTING TONE MARK: not included in any glyphset definition
U+02EB MODIFIER LETTER YANG DEPARTING TONE MARK: not included in any glyphset definition
U+0307 COMBINING DOT ABOVE: try adding one of: syriac, tai-le, coptic, old-permic, malayalam, canadian-aboriginal, tifinagh, math
U+030C COMBINING CARON: try adding one of: cherokee, tai-le
U+031B COMBINING HORN: not included in any glyphset definition 20756 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-hongkong, chinese-simplified, chinese-traditional, cyrillic, japanese, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]

⚠️

WARN Combined length of family and style must not exceed 32 characters.

⚠️ WARN
Name ID 6 'ChocolateClassicalSans-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.

[code: nameid6-too-long]

⚠️

WARN Is there kerning info for non-ligated sequences?

⚠️ WARN
GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️

WARN Are there caret positions declared for every ligature?

⚠️ WARN
This font lacks caret position values for ligature glyphs on its GDEF table.

[code: lacks-caret-pos]

⚠️

WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.

⚠️ WARN
This font file does not have a 'meta' table.

[code: lacks-meta-table]

ℹ️ INFO List all superfamily filepaths

ℹ️ INFO
ofl/chocolateclassicalsans

[code: family-path]

ℹ️ INFO Font contains all required tables?

ℹ️ INFO
This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?

ℹ️ INFO
Found a git repo URL: https://github.com/MoonlitOwen/ChocolateSans

[code: url-found]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file

ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]

ℹ️ INFO EPAR table present in font?

ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818

[code: lacks-EPAR]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?

ℹ️ INFO
These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]

ℹ️ INFO Show hinting filesize impact.

ℹ️ INFO
Hinting filesize impact:

	ofl/chocolateclassicalsans/ChocolateClassicalSans-Regular.ttf
Dehinted Size	9.5Mb
Hinted Size	9.5Mb
Increase	24 bytes
Change	0.0 %

[code: size-impact]

ℹ️ INFO Font has old ttfautohint applied?

ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']

[code: version-not-detected]

[1] Family checks

ℹ️ INFO Check axis ordering on the STAT table.

ℹ️ INFO
All of the fonts lack a STAT table.

[code: summary]

Summary

💥 ERROR	☠ FATAL	🔥 FAIL	⚠️ WARN	⏩ SKIP	ℹ️ INFO	✅ PASS	🔎 DEBUG
0	0	3	19	63	10	156	0
0%	0%	1%	8%	25%	4%	62%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

emmamarichal · 2024-05-16T12:25:11Z

@aaronbell
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
We should update this then, by adding the same url everywhere!

aaronbell · 2024-05-16T12:27:51Z

@aaronbell 🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field. We should update this then, by adding the same url everywhere!

I'm not sure if it makes sense to put my repro name in the copyright string when the upstream owner it MoonlitOwen, but I also think that it makes sense to preserve my repro name as the location of this particular version of the font since it is different than MoonlitOwen's. Thoughts?

emmamarichal · 2024-05-16T12:30:40Z

Ok, then I merge it, and I will notify my colleagues. If there are any issues with that, we will update it.
thanks!

hfhchan · 2024-05-16T18:41:44Z

@hfhchan should we add Tian Haidong in the designers list for this font? (in the metadatas and specimen)

Yes but I have yet to receive a reply from them about the preferred transliteration.

This is fine. TC punctuation works differently than we expect, so the centered positionings are fine.

Yes, I can confirm TC punctuation is always supposed to be in the middle.

Chocolate Classical Sans: Version 1.001 added

9351e1c

Taken from the upstream repo https://github.com/aaronbell/ChocolateSans at commit aaronbell/ChocolateSans@ce0c3c5.

This comment was marked as outdated.

Sign in to view

aaronbell assigned emmamarichal May 15, 2024

Update DESCRIPTION.en_us.html

ff4fd2f

adding a description

emmamarichal self-requested a review May 15, 2024 13:31

emmamarichal requested changes May 15, 2024

View reviewed changes

ofl/chocolateclassicalsans/DESCRIPTION.en_us.html Outdated Show resolved Hide resolved

ofl/chocolateclassicalsans/OFL.txt Outdated Show resolved Hide resolved

Updating font and metadata

17c1057

hfhchan reviewed May 15, 2024

View reviewed changes

ofl/chocolateclassicalsans/DESCRIPTION.en_us.html Outdated Show resolved Hide resolved

emmamarichal added I New Font II CJK Chinese, Japanese, Korean scripts labels May 16, 2024

emmamarichal linked an issue May 16, 2024 that may be closed by this pull request

Add 朱古力黑體 Chocolate Classical Sans #7591

Closed

9 tasks

Update ofl/chocolateclassicalsans/DESCRIPTION.en_us.html

9b5aa76

Co-authored-by: Henry Chan <hfhchan@users.noreply.github.com>

Update DESCRIPTION.en_us.html

b777a70

emmamarichal approved these changes May 16, 2024

View reviewed changes

emmamarichal added the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label May 16, 2024

emmamarichal merged commit 43e65af into main May 16, 2024
6 of 7 checks passed

emmamarichal deleted the gftools_packager_ofl_chocolateclassicalsans branch May 16, 2024 12:30

emmamarichal removed the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chocolate Classical Sans: Version 1.001 added #7664

Chocolate Classical Sans: Version 1.001 added #7664

aaronbell commented May 15, 2024 •

edited

aaronbell commented May 15, 2024

This comment was marked as outdated.

github-actions bot commented May 15, 2024

emmamarichal commented May 15, 2024

emmamarichal commented May 15, 2024

aaronbell commented May 15, 2024

aaronbell commented May 15, 2024

Part II: Outlines / Spacing

aaronbell commented May 15, 2024

github-actions bot commented May 15, 2024

emmamarichal commented May 16, 2024

emmamarichal commented May 16, 2024

github-actions bot commented May 16, 2024

emmamarichal commented May 16, 2024

aaronbell commented May 16, 2024

emmamarichal commented May 16, 2024

hfhchan commented May 16, 2024

Chocolate Classical Sans: Version 1.001 added #7664

Chocolate Classical Sans: Version 1.001 added #7664

Conversation

aaronbell commented May 15, 2024 • edited

aaronbell commented May 15, 2024

This comment was marked as outdated.

github-actions bot commented May 15, 2024

FontBakery report

Experimental checks

All other checks

Summary

emmamarichal commented May 15, 2024

Review - Part I: Fontbakery

emmamarichal commented May 15, 2024

Part II: Outlines / Spacing

aaronbell commented May 15, 2024

aaronbell commented May 15, 2024

Part II: Outlines / Spacing

aaronbell commented May 15, 2024

github-actions bot commented May 15, 2024

FontBakery report

Experimental checks

All other checks

Summary

emmamarichal commented May 16, 2024

emmamarichal commented May 16, 2024

github-actions bot commented May 16, 2024

FontBakery report

Experimental checks

All other checks

Summary

emmamarichal commented May 16, 2024

aaronbell commented May 16, 2024

emmamarichal commented May 16, 2024

hfhchan commented May 16, 2024

aaronbell commented May 15, 2024 •

edited