Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push lists and tags updated #7604

Merged
merged 1 commit into from May 1, 2024
Merged

push lists and tags updated #7604

merged 1 commit into from May 1, 2024

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Apr 26, 2024

No description provided.

chrissimpkins
chrissimpkins requested changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@chrissimpkins chrissimpkins left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jacquard 24 Charted and Jersey 25 Charted require Workspace menu families. I'll work with the Fonts eng team to land this before we merge these updates. Should be by early next week.

to_production.txt Show resolved Hide resolved
to_production.txt Show resolved Hide resolved
@chrissimpkins
Copy link
Collaborator

Jacquard 24 Charted and Jersey 25 Charted require Workspace menu families. I'll work with the Fonts eng team to land this before we merge these updates. Should be by early next week.

Changes opened and review requested from Nate.

@chrissimpkins
Copy link
Collaborator

CI is failing on Knowledge HTML tag checks

@m4rc1e m4rc1e mentioned this pull request Apr 29, 2024
Merged
@m4rc1e m4rc1e closed this in #7613 Apr 29, 2024
@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Apr 29, 2024 •
edited

This should remain open? Or are you preparing a new set of lists?

The menu family updates have not landed yet. Let's please continue to hold on merging this until I confirm that it is ready.

@chrissimpkins chrissimpkins reopened this Apr 29, 2024
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Apr 29, 2024 •
edited

Sorry, Github automatically closed this PR when I merged #7613, which fixes the CI.

@chrissimpkins
Copy link
Collaborator

All set for merge from my standpoint.

@m4rc1e m4rc1e merged commit 3398bee into main May 1, 2024
17 of 18 checks passed
@m4rc1e m4rc1e deleted the push-lists branch May 1, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrissimpkins chrissimpkins chrissimpkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4rc1e @chrissimpkins