New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: new descriptor set backend API #7737
Draft
pixelflinger
wants to merge
14
commits into
main
Choose a base branch
from
ma/descriptor-sets
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
April 4, 2024 23:47
0f1de27
to
80a3519
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
2 times, most recently
from
April 20, 2024 06:59
5979024
to
6353291
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
2 times, most recently
from
May 3, 2024 19:51
1fe426e
to
ec90035
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
May 9, 2024 19:25
ec90035
to
3264e1d
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
2 times, most recently
from
May 23, 2024 20:55
2c066d9
to
79a7528
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
3 times, most recently
from
May 24, 2024 20:38
3fba502
to
9a90b12
Compare
now each material generates its own descriptor-set layout.
In this PR, we "un-hardcode" these: - per-view descriptor-set for shadows - per-view descriptor-set for ssr - per-view descriptor-set for post-processing The descriptor-set for the color pass is still hardcoded. This change uses different layouts for all these cases above and plumbs through the layout handle so it can be set on the pipeline.
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
May 24, 2024 23:28
9a90b12
to
62da111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.