Throw an NSException on Apple platforms when panicking #7720
Conversation
| @@ -139,6 +152,11 @@ void TPanic<T>::panic(char const* function, char const* file, int line, const ch | |||
| va_end(args); | |||
| T e(function, formatFile(file), line, reason); | |||
| e.log(); | |||
|
|
|||
| #if defined(__APPLE__) | |||
| details::throwDarwinException(e); | |||
There was a problem hiding this comment.
Actually, we may want to give users the option of which type of exception they want thrown, maybe through a compile-time flag. @pixelflinger thoughts?
There was a problem hiding this comment.
I'm thinking we should throw the C++ exception first if enabled. If not it'll revert to the darwinException.
If the user wants a darwin exception that can always throw one from their C++ exception handler.
|
Please add a release note line to NEW_RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR. |
| @@ -139,6 +152,11 @@ void TPanic<T>::panic(char const* function, char const* file, int line, const ch | |||
| va_end(args); | |||
| T e(function, formatFile(file), line, reason); | |||
| e.log(); | |||
|
|
|||
| #if defined(__APPLE__) | |||
| details::throwDarwinException(e); | |||
There was a problem hiding this comment.
I'm thinking we should throw the C++ exception first if enabled. If not it'll revert to the darwinException.
If the user wants a darwin exception that can always throw one from their C++ exception handler.
On Apple platforms, we should be throwing an
NSException, which gives us better crash reporting.