Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: Translate the std library Vector, HashMap type and exercise #2058

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vohoanglong0107
Copy link
Contributor

Translate the rest of Rust standard library types section to Vietnamese

po/vi.po Outdated

#: src/std-types/vec.md
msgid ""
"`Vec` implements [`Deref<Target = [T]>`](https://doc.rust-lang.org/std/vec/"
"struct.Vec.html#deref-methods-%5BT%5D), which means that you can call slice "
"methods on a `Vec`."
msgstr ""
"`Vec` implements [`Deref<Target = [T]>`](https://doc.rust-lang.org/std/vec/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate "implements" please!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deref<Target = [T]> here is a trait, and Vec is a struct, in this context Vec implements Deref<Target = [T]> actually means Vec has a method called deref. You can read more about the Deref trait here.
Therefore, this implement is not an actual English verb, it's a Rust term

po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved

#: src/std-types/hashmap.md
msgid ""
"`HashMap` is not defined in the prelude and needs to be brought into scope."
msgstr ""
"`HashMap` không được định nghĩa trong prelude và cần phải được import vào "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest translating HashMap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary anymore. Can you confirm this @qu-ngx?

po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
@@ -6429,53 +6475,63 @@ msgid ""
"stable/std/collections/struct.HashMap.html) to keep track of which values "
"have been seen and how many times each one has appeared."
msgstr ""
"Trong bài tập này, ta sẽ chuyển một cấu trúc dữ liệu đơn giản thành một cấu "
"trúc dữ liệu generic. Chúng ta sẽ sử dụng một [`std::collections::HashMap`]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic not translated man?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is also unnecessary. Can you confirm this @qu-ngx?

Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given some feedbacks on your translation. Can you brush up the translation a little bit? Tks for the contribution btw!

@qu-ngx qu-ngx self-assigned this May 6, 2024
@vohoanglong0107
Copy link
Contributor Author

I want to discuss more how we will translate technical terms in Rust going forward. Could you follow the discussion here?

Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed some unreasonable translation built-in like Counter

Copy link
Collaborator

@daivinhtran daivinhtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qu-ngx I think a lot of the comments are stale after #2062 (comment). Do you mind going through the comments again and mark them resolved if the terms don't need to be translated.

Thanks.

po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
@qu-ngx
Copy link
Collaborator

qu-ngx commented May 9, 2024

@qu-ngx I think a lot of the comments are stale after #2062 (comment). Do you mind going through the comments again and mark them resolved if the terms don't need to be translated.

Thanks.

Sure :D

@mgeisler mgeisler changed the title Translate the std library Vector, HashMap type and exercise into Vietnamese vi: Translate the std library Vector, HashMap type and exercise May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants