Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa : [1/12] Persian translations #2038

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fa : [1/12] Persian translations #2038

wants to merge 5 commits into from

Conversation

alix1383
Copy link
Contributor

@alix1383 alix1383 commented Apr 30, 2024

#671

  • index

  • cargo

  • running-the-course

    Day 1: Morning

    • Welcome
    • Pattern Matching
    • Methods and Traits

    Day 1: Afternoon

    • Welcome
    • Tuples and Arrays
    • References
    • User-Defined Types

Copy link

google-cla bot commented Apr 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alix1383 alix1383 changed the title fa : [1/11] Persian translations fa : [1/12] Persian translations Apr 30, 2024
@mgeisler
Copy link
Collaborator

mgeisler commented May 3, 2024

Please see Formatting for how to install the tools you need to format the .po file. You simply need to run dprint fmt after installing them.

Also note that this PR refreshes the translation while also improving it. This is discouraged because it creates a very large diff, which is hard to review.

The best way of looking at the diff is to use gh with bat:

gh pr diff 2038 | bat -l patch

@alix1383 alix1383 marked this pull request as ready for review May 4, 2024 14:04
@alix1383
Copy link
Contributor Author

alix1383 commented May 8, 2024

@mgeisler
no one review changes...

@DannyRavi
Copy link
Collaborator

hi @alix1383.
I don't understand the changes you made.
It is better to use ‍‍dprint fmt before git commit and push as mentioned above and then push here.

@alix1383
Copy link
Contributor Author

alix1383 commented May 9, 2024

hi @alix1383. I don't understand the changes you made. It is better to use ‍‍dprint fmt before git commit and push as mentioned above and then push here.

I run dprint fmt before committing but nothing changes also gettext already installed

@mgeisler
Copy link
Collaborator

I run dprint fmt before committing but nothing changes also gettext already installed

I think the formatting is fine now — the check passes on GitHub.

@DannyRavi, maybe the confusion is that this PR has a ton of changes because it also includes new English strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants