New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vi: Day 1 Morning - Types and Values translation #2020
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks LGMT! Does this need any changes @daivinhtran
|
||
#: src/types-and-values/exercise.md | ||
msgid "" | ||
"The first and second Fibonacci numbers are both `1`. For n>2, the n'th " | ||
"Fibonacci number is calculated recursively as the sum of the n-1'th and " | ||
"n-2'th Fibonacci numbers." | ||
msgstr "" | ||
"Hai số Fibonacci đầu tiên mang giá trị `1`. Với n > 2, số Fibonacci thứ n sẽ " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, this statement seems like it was not rendered when I was running the mdbook. Instead, it showed the following statements:
The Fibonacci sequence begins with [0,1]. For n>1, the n’th Fibonacci number is calculated recursively as the sum of the n-1’th and n-2’th Fibonacci numbers.
@daivinhtran Could you fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khoaxuantu can you re-run and tell me if it still occurs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good rn. Do you still have problems running mdbook for the first two lines of the docs?
@qu-ngx Yes, it still occurs. The screenshot that I took was when I tried to run mdbook locally, btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khoaxuantu hmm it seems like something must have occurred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khoaxuantu can you try running the mdbook again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Vinh that you'd better provide translation for the base case and recursive case.
Okay! I will change it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good rn. Do you still have problems running mdbook for the first two lines of the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khoaxuantu For now, please lemme try running mdbook on my machine locally.
Here is the translation of Day 1 Morning: Type and Values translation.
It seems like there is no corresponding definition of hygienic macros in Vietnamese, so I think keeping its English word is fine.