Fix serializing additional issue metadata #3911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
603
to
606
| try: | ||
| issue_metadata = json.loads(issue_metadata) | ||
| except: | ||
| pass |
There was a problem hiding this comment.
This seems pretty hacky. I think we need to store the metadata field as something other than a string:string map.
There was a problem hiding this comment.
I will think about a better way to do this, I don't have many ideas as the issue_metadata could be a dictionary of dictionaries
There was a problem hiding this comment.
I think we need to make the field a json-serialized string instead.
jonathanmetzman
force-pushed
the
master
branch
2 times, most recently
from
e7e91a0
to
22e1108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.