-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the severity of HWASAN not being supported by sanitizer.py #3848
base: master
Are you sure you want to change the base?
Conversation
sanitizer.py doesn't support writing hwasan options, this spams the logs heavily, crbug.com/329346758. I will follow up through the bugs in properly setting these options.
Fix format
format
/gcbrun |
I don't have a great understanding of this some I'm a little worried about turning this off for the Android team's ClusterFuzz instance. |
makes sense, I guess involving @marktefftech is our best course of action? FYI regarding the follow up, I'm testing adding the HWASAN_OPTIONS through a wrap.sh in the apk. I had some success but still need to test some more. |
This logging change LGTM As far as a long-term solution, it would be nice to follow the existing convention of setting the This will keep things the same for hwasan as they are for other sanitizers. We can set the options via configuration, for example, using the ClusterFuzz job definitions. Take the |
So using the additional_hwasan_options sounds good. Our hwasan job actually had some (but mislabelled).
Opening Chrome with those hwasan options set is the challenge:
|
e7e91a0
to
22e1108
Compare
@jonathanmetzman noticed a spike in these errors, we are tracking the action of fixing the option handling in https://issues.chromium.org/u/2/issues/329346758, meanwhile, we can reduce the severity of the log.
I am not sure of the actual fix, the HWAsan documentation is a bit lacking. It seems we might be able to set those as an environment variable in a wrap.sh. Can/should this be done by clusterfuzz is to be determined.
Engine fuzzers are not uzing this (most of android fuzzing IIUC?)