Remove CSV Reporter on V2 Branch #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build benchmark 897 completed (commit 9b08350231 by @EricWF) |
|
✅ Build benchmark 905 completed (commit 0bff9681ff by @EricWF) |
|
LGTM |
|
handle conflicts and merge? |
|
Why you remove CSV support? CSV support really easy to open in LibreOffice Calc and build some charts |
|
@KindDragon We're removing support from the core library, but retaining JSON output. It is relatively to write an external tool to read the JSON and generate the CSV should it be necessary, but the library is getting very complicated with the various non-JSON reporters. |
Yes, but not as easy as it is now 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the CSV Reporter entirely from the V2 branch.
This change is needed to support the work of converting to JSON.