Allow for collection of more PMUs than are physically available. #1737
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally we can only collect as many PMUs as we have physical PMU counters because they are managed as a single pinned group and extra requested PMUs will not be collected. With this patch we instead collect each PMU as a separate group once this limit is hit using PMU multiplexing.
|
Could you please split the typos into a preparatory PR? Would #1380 address your usecase? |
dmah42
reviewed
Jan 15, 2024
| // has lower overhead. Group multiplexing doesn't work on all platforms so if | ||
| // that fails try again without using groups. | ||
| bool group_pmus = true; | ||
| retry_without_groups: |
There was a problem hiding this comment.
maybe extracting this into a separate method and calling it with group_pmus as a parameter (and having a return value to indicate whether retry should happen) would be cleaner than a goto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we can only collect as many PMUs as we have physical PMU counters because they are managed as a single pinned group and extra requested PMUs will not be collected. With this patch we instead collect each PMU as a separate group once this limit is hit using PMU multiplexing.
Also fix a number of typos.