Hexagon build changes after rebase #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarchard
reviewed
May 10, 2024
| @@ -1148,7 +1148,7 @@ class DeconvolutionOperatorTester { | |||
| for (size_t g = 0; g < groups(); g++) { | |||
| for (size_t oc = 0; oc < group_output_channels(); oc++) { | |||
| int32_t range = w8dist(rng); | |||
| auto weights_dist = std::uniform_int_distribution<int32_t>(std::min(range, 0), std::max(range, 0)); | |||
| auto weights_dist = std::uniform_int_distribution<int32_t>(std::min<int32_t>(range, 0), std::max<int32_t>(range, 0)); | |||
There was a problem hiding this comment.
INT32_C(0) for the constants instead?
There was a problem hiding this comment.
Quickly tried INT32_C(0) but no luck unfortunately. I will keep investigating if we have better solution than this but this can be merged now as I rebased again.
fbarchard
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had two new errors, so I updated the build recipe for Hexagon.