Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f32 Maxpool RVV implementation microkernels, tests and config changes. #6337

Merged
merged 8 commits into from May 14, 2024

Conversation

KaustubhIMG
Copy link
Contributor

Add f32 Maxpool RVV implementation microkernels for LMUL 1 and 2, tests and config changes.

An rvv generator has been added to facilitate the generation of ukernels with different LMUL sizes.
This commit introduces support for generating RVV f32-maxpool microkernels with various vector lengths in the 'generate-f32-maxpool' script.
This commit introduces microkernels to optimize f32 maxpool operations for different vector lengths. The files f32-maxpool-9p8x-minmax-rvv-*.c are automatically generated by generate-f32-maxpool.sh script.
In this commit, include test cases for the f32-maxpool operation for variable vlenb cases. All test cases have been generated using the scripts/generate-tests.sh script.
In this commit update the f32_maxpool_config to optimized rvv implemetation. Update the rvv.c file in amalgam as per config.
@KaustubhIMG
Copy link
Contributor Author

@fbarchard @allenkelly @bhbruce @keeranroth, If you have time, please help review this PR.

Copy link
Contributor

@bhbruce bhbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on implementation of RVV kernels.

@alankelly
Copy link
Collaborator

Can you please rebase and I will land first thing on Monday?

@KaustubhIMG
Copy link
Contributor Author

@allenkelly I have rebased the patch

@alankelly
Copy link
Collaborator

Thanks importing now

@copybara-service copybara-service bot merged commit 8876fc0 into google:master May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants