New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add f32 Maxpool RVV implementation microkernels, tests and config changes. #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An rvv generator has been added to facilitate the generation of ukernels with different LMUL sizes.
This commit introduces support for generating RVV f32-maxpool microkernels with various vector lengths in the 'generate-f32-maxpool' script.
This commit introduces microkernels to optimize f32 maxpool operations for different vector lengths. The files f32-maxpool-9p8x-minmax-rvv-*.c are automatically generated by generate-f32-maxpool.sh script.
In this commit, include test cases for the f32-maxpool operation for variable vlenb cases. All test cases have been generated using the scripts/generate-tests.sh script.
In this commit update the f32_maxpool_config to optimized rvv implemetation. Update the rvv.c file in amalgam as per config.
@fbarchard @allenkelly @bhbruce @keeranroth, If you have time, please help review this PR. |
bhbruce
reviewed
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on implementation of RVV kernels.
Can you please rebase and I will land first thing on Monday? |
@allenkelly I have rebased the patch |
Thanks importing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add f32 Maxpool RVV implementation microkernels for LMUL 1 and 2, tests and config changes.