Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

you can skip adding empty dev file and infer time is reduced #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Akshaysharma29
Copy link

Hi team, I have added a check so creating an empty dev file can be skipped in colab and this will reduce infer time as well.
Thanks.

Copy link
Collaborator

@eisenjulian eisenjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposed changes, it's a great idea to make inference faster when no test set is needed. To make it not fail silently in the case of missing data, we would prefer if we added an explicit boolean flag to the executable, something like skip_test_set so we can use that in the loops over TestSet to skip the evaluation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants